Hello Caleb,

On 25/12/11 04:09PM, Caleb Schlossin wrote:
> Add snapshot support for several ppc devices for the powernv machines.
> 
> * Adding LPC, ADU, SPI, I2C, core, and chipTOD
> 
> No specific ordering of the patches as this is ongoing development to
> support the PowerVM team. Additional patches for other (non-ppc) devices
> will be coming in separate patch submissions.

Thanks for the patches, can you tell more background on this ? Because
afaik PowerNV doesn't seem to have vmstate mostly, are these enough to
store/restore full PowerNV context ?

The patches look good overall, though I am yet to review in detail.
Some minor nits, LPC only sets vmstate for Power10's LPC, and many
devices vmstate don't have pre/post load handlers, assuming just the
vmstate info is enough in those cases ?

Thanks,
- Aditya G

> 
> Thanks,
> Caleb
> 
> Michael Kowal (1):
>   hw/ppc: Add VMSTATE information for LPC model
> 
> Caleb Schlossin (2):
>   hw/ppc: Add pnv_spi vmstate support
>   hw/ppc: Add pnv_i2c vmstate support
> 
> Angelo Jaramillo (3):
>   hw/ppc: pnv_adu.c added vmstate support
>   hw/ppc: pnv_core.c add vmstate support
>   hw/ppc: pnv_chiptod.c add vmstate support
>   
> 
>  hw/ppc/pnv_adu.c             | 12 +++++++++++
>  hw/ppc/pnv_chiptod.c         | 38 +++++++++++++++++++++++++++++++++++
>  hw/ppc/pnv_core.c            | 22 ++++++++++++++++++++
>  hw/ppc/pnv_i2c.c             | 11 ++++++++++
>  hw/ppc/pnv_lpc.c             | 39 ++++++++++++++++++++++++++++++++++++
>  hw/ssi/pnv_spi.c             | 27 +++++++++++++++++++++++++
>  include/hw/ppc/pnv_chiptod.h |  2 ++
>  7 files changed, 151 insertions(+)
> 
> -- 
> 2.47.3
> 

Reply via email to