On 09/12/2013 01:58 AM, Peter Maydell wrote: > On 12 September 2013 09:25, Claudio Fontana <claudio.font...@huawei.com> > wrote: >> On 02.09.2013 19:54, Richard Henderson wrote: >>> >>> - case INDEX_op_bswap64_i64: >>> - ext = 1; /* fall through */ >>> case INDEX_op_bswap32_i64: >>> + /* Despite the _i64, this is a 32-bit bswap. */ >>> + ext = 0; >>> + /* FALLTHRU */ >>> + case INDEX_op_bswap64_i64: >> >> we waste too much y space here, which gives context and is a scarse resource. >> What about >> >> case INDEX_op_bswap32_i64: /* Despite the _i64, this is a 32-bit bswap. */ >> ext = false; /* FALLTHRU */ > > Consensus in the rest of the code is for /* fall through */ > rather than /* FALLTHRU */ -- there's only 28 of the > latter compared to 169 of the former.
Those 28 may well be all mine too. The fingers still remember that one must use FALLTHRU for lint. ;-) r~
