Philippe Mathieu-Daudé, le mer. 14 nov. 2018 14:10:15 +0100, a ecrit: > With the const qualifier: > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Stefan Hajnoczi, le mer. 14 nov. 2018 14:30:14 +0000, a ecrit: > On Wed, Nov 14, 2018 at 04:36:07PM +0400, Marc-André Lureau wrote: > > -typedef void (*slirp_output)(void *opaque, const uint8_t *pkt, int > > pkt_len); > > +typedef struct SlirpCb { > > + void (*output)(void *opaque, const uint8_t *pkt, int pkt_len); > > +} SlirpCb; > > Please include doc comments for each SlirpCb callback introduced by this > series. Otherwise it will be hard for other people to use libslirp. I have added both and pushed to my tree, thanks! Samuel