On 13.03.20 15:21, Janosch Frank wrote: [..] >>> + } else { >>> + s390_cpu_set_state(S390_CPU_STATE_LOAD, cpu); >>> + } >>> s390_cpu_set_state(S390_CPU_STATE_OPERATING, cpu); >>> } >>> #endif >> >> I don't understand why you set the state to S390_CPU_STATE_LOAD and >> then immediately afterwards to S390_CPU_STATE_OPERATING, especially >> considering that both do the same >> > > Have a look at the specs, wee need to set the load state before setting > the cpu to operating. > > I can add a comment to make it clearer if you want. Yes please. I stumbled over this as well before I read the specs.
- [PATCH v9 13/15] s390x: protvirt: Handle SIGP store ... Janosch Frank
- Re: [PATCH v9 13/15] s390x: protvirt: Handle SI... Christian Borntraeger
- Re: [PATCH v9 13/15] s390x: protvirt: Handl... Janosch Frank
- Re: [PATCH v9 13/15] s390x: protvirt: H... Christian Borntraeger
- Re: [PATCH v9 13/15] s390x: protvirt: H... Christian Borntraeger
- Re: [PATCH v9 13/15] s390x: protvirt: Handle SI... Claudio Imbrenda
- [PATCH v9 09/15] s390x: protvirt: Set guest IPL PSW Janosch Frank
- Re: [PATCH v9 09/15] s390x: protvirt: Set guest... Christian Borntraeger
- Re: [PATCH v9 09/15] s390x: protvirt: Set guest... Claudio Imbrenda
- Re: [PATCH v9 09/15] s390x: protvirt: Set g... Janosch Frank
- Re: [PATCH v9 09/15] s390x: protvirt: S... Christian Borntraeger
- Re: [PATCH v9 09/15] s390x: protvirt: S... Claudio Imbrenda
- Re: [PATCH v9 09/15] s390x: protvirt: S... Claudio Imbrenda
- [PATCH v9 05/15] s390x: protvirt: KVM intercept chan... Janosch Frank
- Re: [PATCH v9 05/15] s390x: protvirt: KVM inter... Claudio Imbrenda
- Re: [PATCH v9 05/15] s390x: protvirt: KVM inter... Cornelia Huck
- [PATCH v9 06/15] s390x: Add SIDA memory ops Janosch Frank
- Re: [PATCH v9 06/15] s390x: Add SIDA memory ops Christian Borntraeger
- Re: [PATCH v9 06/15] s390x: Add SIDA memory ops Claudio Imbrenda
- Re: [PATCH v9 06/15] s390x: Add SIDA memory ops Cornelia Huck
- Re: [PATCH v9 06/15] s390x: Add SIDA memory... Janosch Frank