Samuel Thibault <samuel.thiba...@gnu.org> writes: > Hello, > > Daniel P. Berrangé, le lun. 22 févr. 2021 09:39:41 +0000, a ecrit: >> In general callers shouldn't care about which format was parsed. The use >> of [] is just a mechanism to reliably separate the port from the address. >> Once you have the address part getaddrinfo() will reliably parse the >> address into a sockaddr struct on its own. > > Agreed. > >> The is_v6 flag is only needed >> for the legacy compat needs in slirp, even that is only if we want to >> have strict equivalence with historical behaviour, as opposed to changing >> empty string to mean to listen on both IPv4+6 concurrently.. > > I would say that empty address meaning ipv4+6 looks better to me. > > Doug Evans, le lun. 22 févr. 2021 09:55:09 -0800, a ecrit: >> Hi guys. I think before I submit yet another patchset in this series I need >> someone with authority to define the user API for ipv6 host forwarding. >> Since the hostfwd syntax is parsed in net/slirp.c, Samuel I think that means >> you (based on what I'm reading in MAINTAINERS). > > Well, I'm not maintainer of the user API actually. That'd rather be > Markus Armbruster, now Cc-ed, who devises the command-line options, > QAPI, etc.
I rarely devise, I just try to keep things sane by reviewing and advising, with the help of others. >> Based on what Maxim originally wrote I was going with addresses wrapped in [] >> mean ipv6, but Daniel does not want that. > > Specifying [127.0.0.1] would be odd, but for instance > > ssh localhost -D '[127.0.0.1]':23456 > > happens to listen on 127.0.0.1. So I would say that common practice > really is that [] only matters for syntax, and not semantic. I believe common syntactic practice is to use [brackets] only around numeric IPv6 addresses. E.g. socat(1): IP address An IPv4 address in numbers-and-dots notation, an IPv6 address in hex notation enclosed in brackets, or a hostname that resolves to an IPv4 or an IPv6 address. Examples: 127.0.0.1, [::1], www.dest-unreach.org, dns1 [...]