Eric Blake <ebl...@redhat.com> writes:
> On Mon, Sep 18, 2023 at 04:41:24PM +0200, Markus Armbruster wrote:
>> When all we do with an Error we receive into a local variable is
>> propagating to somewhere else, we can just as well receive it there
>> right away.
>>
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>>
>> ret = qemu_rdma_alloc_pd_cq(rdma);
>> if (ret) {
>> - ERROR(temp, "rdma migration: error allocating pd and cq! Your
>> mlock()"
>> + ERROR(errp, "rdma migration: error allocating pd and cq! Your
>> mlock()"
>> " limits may be too low. Please check $ ulimit -a # and
>> "
>> "search for 'ulimit -l' in the output");
>
> Not this patch's problem, but noticing it while here:
>
> it would help if we had a consistent style on whether to break long
> strings after the space instead of carrying the space to the next
> line, rather than using both styles in the same concatenated string.
Oh yes. I prefer to break lines before space, because leading space is
more visible than trailing space.
However, I elected to refrain from touching error messages in this
series. It's long enough as it is.
