Ugh, there's something other than "merge master into branch" in that commit... Ok, I'll going to merge it as well. Regards.
On Wed, May 27, 2015 at 9:39 AM, Etienne Trimaille < etienne.trimai...@gmail.com> wrote: > Thanks Giuseppe for the merge. > In the third commit, I changed the new feature 'createView' from Hugo to > use the 'getSqlQuery'. But this commit hasn't been pushed. It would be > nice to use always this function, if someone wants to create a view with > the selected query. > > Regards, > Etienne > > 2015-05-27 1:07 GMT+02:00 Giuseppe Sucameli <brush.ty...@gmail.com>: > >> Merged and closed both PR. >> Best regards. >> Giuseppe >> >> On Tue, May 26, 2015 at 1:25 PM, Etienne Trimaille < >> etienne.trimai...@gmail.com> wrote: >> >>> Sorry for the double merge. It comes after the work from Hugo. >>> >>> This feature was on the changelog for 2.8, but the selected query >>> couldn't be loaded on the map canvas. We could only execute the selected >>> part to see the table in the sql window. That's why there is a backport. >>> >>> >>> >>> 2015-05-26 10:54 GMT+02:00 Giuseppe Sucameli <brush.ty...@gmail.com>: >>> >>>> Hi, >>>> I agree the changes are good, >>>> >>>> I don't know if the double merge on PR 1999 could break something, but >>>> we can just pick the right commit. >>>> >>>> >>>> >>>> On Tue, May 26, 2015 at 9:46 AM, René-Luc Dhont <rldh...@gmail.com> >>>> wrote: >>>> >>>>> I looked at the code and it's pretty simple. If some code are >>>>> selected, the selection has run otherwise all the code has run. >>>>> >>>>> Some one to agree this PR ? >>>>> >>>>> Le 25/05/2015 19:08, Paolo Cavallini a écrit : >>>>> >>>>>> Am 25.05.2015 um 18:40 schrieb Etienne Trimaille: >>>>>>> >>>>>>>> I opened two PR one month ago about to run only a selected query in >>>>>>>> the db manager. >>>>>>>> >>>>>>>> https://github.com/qgis/QGIS/pull/1999 >>>>>>>> https://github.com/qgis/QGIS/pull/2000 >>>>>>>> >>>>>>>> Could you please review them and merge ? >>>>>>>> >>>>>>> Agreed, it would be good to have them. >>>>>> Anyone can review them? >>>>>> Thanks. >>>>>> >>>>> >>>>> _______________________________________________ >>>>> Qgis-developer mailing list >>>>> Qgis-developer@lists.osgeo.org >>>>> http://lists.osgeo.org/mailman/listinfo/qgis-developer >>>>> >>>> >>>> >>>> >>>> -- >>>> Giuseppe Sucameli >>>> >>>> _______________________________________________ >>>> Qgis-developer mailing list >>>> Qgis-developer@lists.osgeo.org >>>> http://lists.osgeo.org/mailman/listinfo/qgis-developer >>>> >>> >>> >> >> >> -- >> Giuseppe Sucameli >> > > -- Giuseppe Sucameli
_______________________________________________ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer