Hi, this report applies to version 1.2, 1.1.x and trunk
I am currently having a strange issue, but fortunately it's explainable.
I have a job that combines some of my images (e.g all 16x16 icons and all 32x32
icons). Sometimes the order of one of the combined images changes...this
happens on one day, and changes back on another.
The reason for this is:
Because the image list that is used in the generator[1] is a map
(or whatever this is called in Python ;) ) there is no "order" in the keys.
Therefore the combined images might not always have the same order.
An easy fix for this would be to just sort the input variable (which is a array
that has an order):
<code class=Python>
input = sorted(clippedImages.keys())
</code>
I know that the order is not important when you generate the complete
application, but
1. I like things to be predictable ;)
2. We are keeping the meta-files and the combined images under version-control
and therefore it's not nice when we have modifications in our working-copy
although there has been no change at all.
I know that this will probable change many combined images, but after that it
will stay this way and the order is _predictable_.
Attached you will find a patch (based on trunk). The two images just show the
difference of a combined image that is configured like this:
<code class=JSON>
{
"jobs" :
{
//...
"common" : {
"let" : {
// resource path:
"RESPATH" : "source/resource",
// common output path:
"COMBI_PATH" : "${RESPATH}/myapp/combined"
}
},
//...
"image-combine" : {
"extend" : [ "common" ],
"combine-images" : {
"images" : {
"${COMBI_PATH}/counter.png" : {
"prefix" : [ "${RESPATH}" ],
"input" :
[
{
"prefix" : [ "${RESPATH}" ],
"files" : [ "${RESPATH}/myapp/counter/*.png" ]
}
]
}
}
}
}
}
//...
}
</code>
By the way: I don#t care _what_ order the image has, I only like it to be the
same every day ;) .
What's your opinion about this?
File a bug?
Cheers,
Peter
[1] tool\pylib\generator\Generator.py
Index: Generator.py
===================================================================
--- Generator.py (Revision 22995)
+++ Generator.py (Arbeitskopie)
@@ -1545,7 +1545,7 @@
clippedImages = getClippedImagesDict(imgspec)
# collect list of all input files, no matter where the come from
- input = clippedImages.keys()
+ input = sorted(clippedImages.keys())
# collect layout property
if 'layout' in imgspec:
<<inline: counter_pre.png>>
<<inline: counter_post.png>>
------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
