On Sun, Jan 9, 2011 at 11:00 PM, gia...@gmail.com <gia...@gmail.com> wrote: > Hi all, > I built rdkit 2010.12 beta3 binaries for Fedora 13 and 14 (64bit) and > uploaded them on my fedorapeople space: > http://giallu.fedorapeople.org/rdkit > > The old patches I added to build 2010.09 were folded into the current > release (thanks Greg!), however, I'm still doing some changes I'd like > to note here. > > 1. remove static libraries. > It seems in October a change in the RDKitUtils.cmake file added a > complementary set of *_static libraries to be created and installed > alongside the usual shared ones. Right now, I'm just patching out this > behaviour (no static libs are allowed in Fedora anyway) but I could > think about a couple (IMHO better) alternatives: > > * build and use static libs only when BUILD_SHARED_LIBS:BOOL=OFF (this > is the default behaviour for cmake) > * add some RDKIT_BUILD_STATIC_LIBS flag to conditionally build the static libs
I added a RDK_INSTALL_STATIC_LIBS flag. This defaults to ON, but if you set it to OFF, then the _static libraries will not be copied to the lib dir. I think this should solve the rpm problems. > 2. build postgresql against shared libraries > this is basically a consequence of the first patch, I restored the > previous behaviour of building the cartridge against shared libraries. > > 3. a bunch of files have the executable bit set, while they shouldn't. > To find all of them I used: > find Code/ -name "*.cpp" -o -name "*.ll" -o -name "*.yy" -o -name > "*.hpp" -executable > the same goes for ReleaseNotes.txt Fixed in svn. > > > Now few things I noticed but not (yet) fixed in the packages > > * I'm not sure the directory rdkit/Chem/tests is useful in the installed tree it's not. I renamed it to rdkit/Chem/test_data. It should no longer be installed. > * an empty file rdkit/Excel/outf is installed, probably it should not > even exist in SVN removed. > * rpmlint complains about "exit()" being called in two libraries > (libSmilesParse and libSLNParse) As Riccardo pointed out; this is a flex bug, so we can't really do anything about it. Thanks again for all your effort, -greg ------------------------------------------------------------------------------ Protect Your Site and Customers from Malware Attacks Learn about various malware tactics and how to avoid them. Understand malware threats, the impact they can have on your business, and how you can protect your company and customers by using code signing. http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Rdkit-discuss mailing list Rdkit-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rdkit-discuss
