gengliangwang commented on code in PR #46309:
URL: https://github.com/apache/spark/pull/46309#discussion_r1585642022


##########
core/src/main/scala/org/apache/spark/util/logging/RollingPolicy.scala:
##########
@@ -53,8 +54,10 @@ private[spark] class TimeBasedRollingPolicy(
 
   import TimeBasedRollingPolicy._
   if (checkIntervalConstraint && rolloverIntervalMillis < 
MINIMUM_INTERVAL_SECONDS * 1000L) {
-    logWarning(s"Rolling interval [${rolloverIntervalMillis/1000L} seconds] is 
too small. " +
-      s"Setting the interval to the acceptable minimum of 
$MINIMUM_INTERVAL_SECONDS seconds.")
+    logWarning(log"Rolling interval [${MDC(TIME_UNITS, 
rolloverIntervalMillis/1000L)} " +
+      log"seconds] is too small. " +
+      log"Setting the interval to the acceptable minimum of " +
+      log"${MDC(MIN_TIME, MINIMUM_INTERVAL_SECONDS)} seconds.")

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to