Github user xwu0226 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13212#discussion_r63992055
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -1387,6 +1387,27 @@ class SparkContext(config: SparkConf) extends 
Logging with ExecutorAllocationCli
       }
     
       /**
    +    * Return a list of file paths that are added to resources.
    +    * If file paths are provided, return the ones that are added to 
resources.
    +    */
    +  def listFiles(files: Seq[String] = Seq.empty[String]): Seq[String] = {
    --- End diff --
    
    @rxin Just one concern about thiss one. It is possible that users just 
invoked listFiles or listJars directly with sparkContext. Do we want to provide 
filtering for this case? Right now, I have a [test 
case](https://github.com/xwu0226/spark/blob/21b092ab84b22abec93fde1fc1ca177db68d9f0d/core/src/test/scala/org/apache/spark/SparkContextSuite.scala#L159-L176)
 that covers this case. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to