Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69147983
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -165,68 +168,53 @@ public Object get(int ordinal, DataType dataType) {
@Override
public boolean getBoolean(int ordinal) {
assertIndexIsValid(ordinal);
- final int offset = getElementOffset(ordinal);
- if (offset < 0) return false;
- return Platform.getBoolean(baseObject, baseOffset + offset);
+ return Platform.getBoolean(baseObject, getFieldOffset(ordinal, 1));
}
@Override
public byte getByte(int ordinal) {
assertIndexIsValid(ordinal);
- final int offset = getElementOffset(ordinal);
- if (offset < 0) return 0;
- return Platform.getByte(baseObject, baseOffset + offset);
+ return Platform.getByte(baseObject, getFieldOffset(ordinal, 1));
}
@Override
public short getShort(int ordinal) {
assertIndexIsValid(ordinal);
- final int offset = getElementOffset(ordinal);
- if (offset < 0) return 0;
- return Platform.getShort(baseObject, baseOffset + offset);
+ return Platform.getShort(baseObject, getFieldOffset(ordinal, 2));
}
@Override
public int getInt(int ordinal) {
assertIndexIsValid(ordinal);
- final int offset = getElementOffset(ordinal);
- if (offset < 0) return 0;
- return Platform.getInt(baseObject, baseOffset + offset);
+ return Platform.getInt(baseObject, getFieldOffset(ordinal, 4));
}
@Override
public long getLong(int ordinal) {
assertIndexIsValid(ordinal);
- final int offset = getElementOffset(ordinal);
- if (offset < 0) return 0;
- return Platform.getLong(baseObject, baseOffset + offset);
+ return Platform.getLong(baseObject, getFieldOffset(ordinal, 8));
}
@Override
public float getFloat(int ordinal) {
assertIndexIsValid(ordinal);
- final int offset = getElementOffset(ordinal);
- if (offset < 0) return 0;
- return Platform.getFloat(baseObject, baseOffset + offset);
+ return Platform.getFloat(baseObject, getFieldOffset(ordinal, 4));
}
@Override
public double getDouble(int ordinal) {
assertIndexIsValid(ordinal);
- final int offset = getElementOffset(ordinal);
- if (offset < 0) return 0;
- return Platform.getDouble(baseObject, baseOffset + offset);
+ return Platform.getDouble(baseObject, getFieldOffset(ordinal, 8));
}
@Override
public Decimal getDecimal(int ordinal, int precision, int scale) {
assertIndexIsValid(ordinal);
- final int offset = getElementOffset(ordinal);
- if (offset < 0) return null;
-
+ if (isNullAt(ordinal)) {
+ return null;
+ }
--- End diff --
write them in one line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
