Github user avulanov commented on a diff in the pull request:
https://github.com/apache/spark/pull/15382#discussion_r82507085
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -757,7 +758,10 @@ private[sql] class SQLConf extends Serializable with
CatalystConf with Logging {
def variableSubstituteDepth: Int = getConf(VARIABLE_SUBSTITUTE_DEPTH)
- def warehousePath: String = new Path(getConf(WAREHOUSE_PATH)).toString
+ def warehousePath: String = {
+ val path = new Path(getConf(WAREHOUSE_PATH))
+ FileSystem.get(path.toUri, new
Configuration()).makeQualified(path).toString
--- End diff --
There are two concerns here. Linux paths will work without adding
`file://`, and Windows will not. That might lead to confusion. Also, I doubt
that both Windows and Linux users typically add `file://` if they specify a
local path. As a rule of thumb, if no schema is given, then by default it is a
local path. The second concern is that `URI` requires percent encoded string,
so it does not work with white spaces or special symbols in the path. As far as
I understand, URI is for URIs and not for paths. If we want to use URI then we
need to change the variable name to `warehouseURI` and add a proper
documentation about this configuration parameter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
