Github user koeninger commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15702#discussion_r86066376
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -536,6 +535,41 @@ class Dataset[T] private[sql](
       }
     
       /**
    +   * :: Experimental ::
    +   * Defines an event time watermark for this [[Dataset]]. A watermark 
tracks a point in time
    +   * before which we assume no more late data is going to arrive.
    +   *
    +   * Spark will use this watermark for several purposes:
    +   *  - To know when a given time window aggregation can be finalized and 
thus can be emitted when
    +   *    using output modes that do not allow updates.
    +   *  - To minimize the amount of state that we need to keep for on-going 
aggregations.
    --- End diff --
    
    For append, this sounds like the intention is emit only once watermark has 
passed, and drop state.
    But for other output modes, it's not clear from reading this what the 
effect of the watermark on emission and dropping state is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to