Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18421#discussion_r126273439
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
@@ -181,6 +182,151 @@ class StatisticsSuite extends
StatisticsCollectionTestBase with TestHiveSingleto
}
}
+ private val SELECT_FROM_SRC = "SELECT '1', 'A' from src"
+
+ test("analyze single partition") {
+ val tableName = "analyzeTable_part"
+
+ def queryStats(ds: String): CatalogStatistics = {
+ val partition =
+
spark.sessionState.catalog.getPartition(TableIdentifier(tableName), Map("ds" ->
ds))
+ partition.stats.get
+ }
+
+ def createPartition(ds: String, query: String): Unit = {
+ sql(s"INSERT INTO TABLE $tableName PARTITION (ds='$ds') $query")
+ }
+
+ withTable(tableName) {
+ sql(s"CREATE TABLE $tableName (key STRING, value STRING) PARTITIONED
BY (ds STRING)")
+
+ createPartition("2010-01-01", SELECT_FROM_SRC)
+ createPartition("2010-01-02", s"$SELECT_FROM_SRC UNION ALL
$SELECT_FROM_SRC")
+ createPartition("2010-01-03", SELECT_FROM_SRC)
+
+ sql(s"ANALYZE TABLE $tableName PARTITION (ds='2010-01-01') COMPUTE
STATISTICS NOSCAN")
+
+ sql(s"ANALYZE TABLE $tableName PARTITION (ds='2010-01-02') COMPUTE
STATISTICS NOSCAN")
+
+ assert(queryStats("2010-01-01").rowCount === None)
+ assert(queryStats("2010-01-01").sizeInBytes === 2000)
+
+ assert(queryStats("2010-01-02").rowCount === None)
+ assert(queryStats("2010-01-02").sizeInBytes === 2*2000)
+
+ sql(s"ANALYZE TABLE $tableName PARTITION (ds='2010-01-01') COMPUTE
STATISTICS")
+
+ sql(s"ANALYZE TABLE $tableName PARTITION (ds='2010-01-02') COMPUTE
STATISTICS")
+
+ assert(queryStats("2010-01-01").rowCount.get === 500)
+ assert(queryStats("2010-01-01").sizeInBytes === 2000)
+
+ assert(queryStats("2010-01-02").rowCount.get === 2*500)
+ assert(queryStats("2010-01-02").sizeInBytes === 2*2000)
+ }
+ }
+
+ test("analyze a set of partitions") {
+ val tableName = "analyzeTable_part"
+
+ def queryStats(ds: String, hr: String): Option[CatalogStatistics] = {
+ val tableId = TableIdentifier(tableName)
+ val partition =
+ spark.sessionState.catalog.getPartition(tableId, Map("ds" -> ds,
"hr" -> hr))
+ partition.stats
+ }
+
+ def assertStats(ds: String, hr: String, rowCount: BigInt, sizeInBytes:
BigInt): Unit = {
+ val stats = queryStats(ds, hr).get
+ assert(stats.rowCount === Some(rowCount))
+ assert(stats.sizeInBytes === sizeInBytes)
+ }
+
+ def assertSizeInBytesStats(ds: String, hr: String, sizeInBytes:
BigInt): Unit = {
+ val stats = queryStats(ds, hr).get
+ assert(stats.rowCount === None)
+ assert(stats.sizeInBytes === sizeInBytes)
+ }
+
+ def createPartition(ds: String, hr: Int, query: String): Unit = {
+ sql(s"INSERT INTO TABLE $tableName PARTITION (ds='$ds', hr=$hr)
$query")
+ }
+
+ withTable(tableName) {
+ sql(s"CREATE TABLE $tableName (key STRING, value STRING) PARTITIONED
BY (ds STRING, hr INT)")
+
+ createPartition("2010-01-01", 10, SELECT_FROM_SRC)
+ createPartition("2010-01-01", 11, SELECT_FROM_SRC)
+ createPartition("2010-01-02", 10, SELECT_FROM_SRC)
+ createPartition("2010-01-02", 11, s"$SELECT_FROM_SRC UNION ALL
$SELECT_FROM_SRC")
+
+ sql(s"ANALYZE TABLE $tableName PARTITION (ds='2010-01-01') COMPUTE
STATISTICS NOSCAN")
+
+ assertSizeInBytesStats("2010-01-01", "10", 2000)
+ assertSizeInBytesStats("2010-01-01", "11", 2000)
+ assert(queryStats("2010-01-02", "10") === None)
+ assert(queryStats("2010-01-02", "11") === None)
+
+ sql(s"ANALYZE TABLE $tableName PARTITION (ds='2010-01-02') COMPUTE
STATISTICS NOSCAN")
+
+ assertSizeInBytesStats("2010-01-01", "10", 2000)
+ assertSizeInBytesStats("2010-01-01", "11", 2000)
+ assertSizeInBytesStats("2010-01-02", "10", 2000)
+ assertSizeInBytesStats("2010-01-02", "11", 2*2000)
+
+ sql(s"ANALYZE TABLE $tableName PARTITION (ds='2010-01-01') COMPUTE
STATISTICS")
+
+ assertStats("2010-01-01", "10", 500, 2000)
+ assertStats("2010-01-01", "11", 500, 2000)
+ assertSizeInBytesStats("2010-01-02", "10", 2000)
+ assertSizeInBytesStats("2010-01-02", "11", 2*2000)
+
+ sql(s"ANALYZE TABLE $tableName PARTITION (ds='2010-01-02') COMPUTE
STATISTICS")
+
+ assertStats("2010-01-01", "10", 500, 2000)
+ assertStats("2010-01-01", "11", 500, 2000)
+ assertStats("2010-01-02", "10", 500, 2000)
+ assertStats("2010-01-02", "11", 2*500, 2*2000)
+ }
+ }
+
+ test("analyze non-existent partition") {
+ val tableName = "analyzeTable_part"
+ withTable(tableName) {
+ sql(s"CREATE TABLE $tableName (key STRING, value STRING) PARTITIONED
BY (ds STRING)")
+
+ sql(s"INSERT INTO TABLE $tableName PARTITION (ds='2010-01-01')
SELECT * FROM src")
+
+ intercept[AnalysisException] {
+ sql(s"ANALYZE TABLE $tableName PARTITION (hour=20) COMPUTE
STATISTICS")
+ }
+
+ intercept[NoSuchPartitionException] {
+ sql(s"ANALYZE TABLE $tableName PARTITION (ds='2011-02-30') COMPUTE
STATISTICS")
+ }
+ }
+ }
+
+ test("analyzing views is not supported") {
--- End diff --
I think this is caused by rebase? please remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
