Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22063#discussion_r212504250
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
 ---
    @@ -40,7 +40,14 @@ import org.apache.spark.sql.types.DataType
     case class UserDefinedFunction protected[sql] (
         f: AnyRef,
         dataType: DataType,
    -    inputTypes: Option[Seq[DataType]]) {
    +    inputTypes: Option[Seq[DataType]],
    +    nullableTypes: Option[Seq[Boolean]] = None) {
    --- End diff --
    
    +1 to all your comments. I'm overhauling this whole PR and will force push 
with a rebase once it seems to basically work.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to