Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22274#discussion_r214244580
  
    --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
    @@ -3633,7 +3633,8 @@ test_that("catalog APIs, currentDatabase, 
setCurrentDatabase, listDatabases", {
       expect_equal(currentDatabase(), "default")
       expect_error(setCurrentDatabase("default"), NA)
       expect_error(setCurrentDatabase("zxwtyswklpf"),
    -        "Error in setCurrentDatabase : analysis error - Database 
'zxwtyswklpf' does not exist")
    +               paste("Error in setCurrentDatabase : analysis error - 
Database",
    --- End diff --
    
    I'd use paste0 instead to make clear about the implicit space that should 
be after `Database`
    
    ie. `paste0("Error in setCurrentDatabase : analysis error - Database ",  
"'zxwtyswklpf' does not exist"))


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to