Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23054#discussion_r234569150
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -1594,6 +1594,15 @@ object SQLConf {
             "WHERE, which does not follow SQL standard.")
           .booleanConf
           .createWithDefault(false)
    +
    +  val LEGACY_ALIAS_NON_STRUCT_GROUPING_KEY =
    +    buildConf("spark.sql.legacy.dataset.aliasNonStructGroupingKey")
    --- End diff --
    
    Maybe aliasNonStructGroupingKeyAsValue, and default to true.
    
    Then we can remove this in the future.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to