Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r236488306
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -86,11 +88,14 @@ private[spark] class ExecutorPodsAllocator(
s" cluster after $podCreationTimeout milliseconds despite the
fact that a" +
" previous allocation attempt tried to create it. The executor
may have been" +
" deleted but the application missed the deletion event.")
- Utils.tryLogNonFatalError {
- kubernetesClient
- .pods()
- .withLabel(SPARK_EXECUTOR_ID_LABEL, execId.toString)
- .delete()
+
+ if (shouldDeleteExecutors) {
+ Utils.tryLogNonFatalError {
+ kubernetesClient
+ .pods()
+ .withLabel(SPARK_EXECUTOR_ID_LABEL, execId.toString)
--- End diff --
I just run multiple jobs in parallel:
```
NAME READY STATUS RESTARTS AGE
spark-pi-1543281035622-driver 1/1 Running 0 2m
spark-pi-1543281035622-exec-1 1/1 Running 0 1m
spark-pi-1543281098418-driver 0/1 Completed 0 1m
spark-pi-1543281107591-driver 0/1 Completed 0 57s
```
The long running was not terminated...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
