Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/23152#discussion_r237359357
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/FilterEstimationSuite.scala
---
@@ -821,6 +822,32 @@ class FilterEstimationSuite extends
StatsEstimationTestBase {
expectedRowCount = 3)
}
+ test("ColumnStatsMap tests") {
--- End diff --
Hi @viirya , thanks for your review. Here the `FilterEstimation` works
because we only call `FilterEstimation.estimate` to check it, in which we check
if `rowCount.isEmpty` first and shortcut the estimation. If `rowCount` is not
empty, we should always has a `min` and `max` in the stats, unless it is
malformed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
