Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23148
I played with this a little locally, and yeah it does reformat entire files
that are in the diff, and most of what it does is fixing stuff we probably
wouldn't ask for in a PR review. For example is it possible to disable its
preference for putting closing braces and parens on the next line? as in the
comment at https://github.com/apache/spark/pull/23148#issuecomment-442243410 .
And maybe less aggressive about putting args to a method each on their own
line.
There isn't a mode that would somehow just reformat lines that are being
changed, BTW?
This is already useful in that we can just ask people to run dev/scalafmt
(I'll update developer guids) as the output style looks _also_ just fine. I
won't try to have this automatically add the formatting to the build.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
