Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/23171
  
    I thought InSwitch logically is the same as InSet, in which all the child 
expressions are literals?
    
    On Mon, Dec 03, 2018 at 8:38 PM, Wenchen Fan < notificati...@github.com > 
wrote:
    
    > 
    > 
    > 
    > I think InSet is not an optimized version of In , but just a way to
    > separate the implementation for different conditions (the length of the
    > list). Maybe we should do the same thing here, create a InSwitch and
    > convert In to it when meeting some conditions. One problem is, In and 
InSwitch
    > is same in the interpreted version, maybe we should create a base class
    > for them.
    > 
    > 
    > 
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub (
    > https://github.com/apache/spark/pull/23171#issuecomment-443968486 ) , or 
mute
    > the thread (
    > 
https://github.com/notifications/unsubscribe-auth/AATvPDTQic0Ii5UD40m_Uj5kMVy4pNExks5u1fxPgaJpZM4Y4P4J
    > ).
    > 
    > 
    >


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to