Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/23259
  
    thanks @maropu for starting it!
    
    > Which SQL standard does Spark SQL follow (e.g., 2011 or 2016)?
    I think SQL 2011 is good, but if we can't find a public version, maybe it's 
also OK to follow 
[postgres](https://github.com/postgres/postgres/blob/ee2b37ae044f34851baba69e9ba737077326414e/src/backend/parser/gram.y#L15366)
    
    > Where should we hanlde reserved key words?
    I think it should be `SqlBase.g4`, but a problem is, the g4 files defines 
`non-reserved` keywords, not `reserved` ones. Maybe we need to update it.
    
    > Where should we docment the list of reserved/non-reserved key words?
    I think the new files you created in this PR is a good place to document it


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to