Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23201#discussion_r240090192
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala
 ---
    @@ -121,7 +122,26 @@ private[sql] class JsonInferSchema(options: 
JSONOptions) extends Serializable {
                 DecimalType(bigDecimal.precision, bigDecimal.scale)
             }
             decimalTry.getOrElse(StringType)
    -      case VALUE_STRING => StringType
    +      case VALUE_STRING =>
    +        val stringValue = parser.getText
    --- End diff --
    
    the partition feature is shared between all the file-based sources, I think 
it's an overkill to make it differ with different data sources.
    
    The simplest solution to me is asking all text sources to follow the 
behavior of partition value type inference.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to