On Thursday, July 07, 2011, Daren Beattie wrote: I was hooking my set of pups when my run got canned at the last minute, so I find myself with a night off unexpectedly.
> LilyPondExporter::write() and LilyPondExporter::writeBar()... > I'm tempted to break some chunks of code out into separate methods and, if > warranted, separate classes. This is something where if you're tempted to have a go at it, you might as well have a go at it, and see what comes out. The best motivation is that which comes from within, and the best project to undertake is the one that scratches that itch you've been having in the center of your back for awhile. The LilyPond exporter is a big complicated mess that's definitely hard to work on. I really couldn't begin to imagine how I would refactor this whole mess at this point, which means there's virtually no danger of your stepping on any toes if you want to try radical new things. I care about results. If the results get better, or if you can produce the same results with better code, then go have fun with it, and see what you come up with. It does sound like all of this wants to be played with in a branch, even though trunk/ is all but stagnant at the moment. The LilyPond engine is pretty important stuff, and there might be a release between when you start on this and when your refactored engine is performing up to snuff. Probably not, but I'd rather play it safe here, and treat trunk/ like a perpetual release candidate. > Would everyone be amenable to the refactorings and additional directory > layer? It does seem like overkill having to add new layers of directory structure, but that is an extremely minor quibble, and you should do it if your feeling that it's necessary is strong enough to override a very minor objection. > Secondly, I'd like to get some automated unit tests in place for the work I > want to do. And then that stuff again. I read back over what I wrote right before bed at the end of a 14-hour work day, and it sounded a little harsh, even though it was more intended to come off humorous. I'm expecting you'll go ahead with the unit testing, and offer some idiot's guide explanation of what you're up to along the way. -- D. Michael McIntyre ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
