On Monday, September 05, 2011, Tom Breton (Tehom) wrote:
> Let me know if there is any trouble applying it.
Will do. I might get back to this later today, but I don't have time just at
the moment.
> * Leave everything where it is
> * Move beatTimeRatioToTempo into Composition, so the triangle is together.
> * Move all 3 to some new location
>
> What do you think?
I'd probably be inclined to either leave it where it is, or do the least
amount of moving to get it all together, which would mean moving it into
Composition.
> I'd like to give Segment another copy ctor that takes also a boolean flag
> to make it not copy events.
>
> What do you think?
I'm not sure I get the point of cloning a segment empty, but it shouldn't be
hard to do this without creating surprising new behavior, so what do I care?
> ****** Code that might be shared - but probably not
Over time I have generally become less inclined to go to the trouble to pull
code like that out into something that can be shared, and more inclined to
just block copy and be done with it.
Code like that doesn't get reused in the future as often as you might think,
and this is usually kind of a disappointing exercise when you look back on how
elegant a job you've done, and for what?
Having said that, elegance is never really a bad thing, so it's your call.
> ****** Crediting myself appropriately
> So does that mean you add me to the page that AUTHORS points to, or I
> credit myself in the individual file headers (but there's no place for
> that in the template)? What's the policy on this?
People who want credit generally just stick a line in the header, like this
one:
Rosegarden
A MIDI and audio sequencer and musical notation editor.
Copyright 2000-2011 the Rosegarden development team.
This file is Copyright 2006-2009
D. Michael McIntyre <[email protected]>
Other copyrights also apply to some parts of this work. Please
[...]
The release notes mention everyone who contributed something for that
particular release, but don't give point for point credit of who did what. I
used to keep up with all of that in a very detailed way, but it just got to be
too much work.
I keep the future release note at
http://rosegardenmusic.com/wiki/dev:next_version
Where you'd fit into that at this point is your feature would go under "New
Features" and your name would go under "Other people who contributed to
Rosegarden development." Features may or may not get specific mention in the
introductory blurb at the top.
Then, of course, I try to remember to add everyone to the authors page on the
rosegardenmusic.com website. If I forget anyone, it's not because I think
their contributions were insignificant, it's just because there's an awful lot
of paperwork to keep up with around here, and I lose track easily.
Now then, I'll be back later to actually look at your patch. Sorry I'm not
jumping on it right away, because it *does* sound very interesting!
--
D. Michael McIntyre
------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
