Hello Tom, See my in-line comments. I hope the will be helpful.
> It happened just for overlapping long duration percussion > notes. > Percussion - sometimes just certain affected keys - stopped > sounding about > the time the noteoffs "played". > > The way the percussion editor makes notes, some are quite > long. Manually > making the notes short fixed it, but I can hardly expect > users to do that. > > I fixed it by making InternalSegmentMapper treat percussion > notes' > durations specially, so percussion notes are always treated > as very short. > I'm not sure this is the best solution, it just seemed to > be the most > conservative solution. Some users will not like this at all, since they may have mapped samples to specific keys, and used the percussion switch to enable key mapping and rely on current RG behavior when entering notation for it. Shortening these notes will have poor results if these samples are setup to cut off when the note off's are received. But you are correct that many percussion setups will work with this solution, but this will create a regression for some people. > > I think it happened when I added noteoffs so that MidiFile > could see them. > If I just turned the noteoffs off, MidiFile wouldn't work > right. I'm not > sure why AlsaDriver escaped this problem before now, since > it has always > made its own noteoffs and doesn't treat percussion > specially. Possibly > because it tracks noteoffs and removes them when it gets new > notes. Warts and all, I did exactly that in the AlsaDriver. I coded a map that tracked note ons, per instrument, so RG could coordinate their note offs (during recording). Of course when multiple note ons are received prior to a note off, It is difficult to know which note off to match it to -- I think I tried to match it to the one that had sounded first. But its been a while. I'm not really in a position to dig around in the code and offer real help on this though. Sincerely, Julie S. ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
