> On 01/04/2013 02:22 PM, Tom Breton (Tehom) wrote:
>
>> m_selectedInstrument->setSendBankSelect(bool). So if variation is set,
>> then cleared, Instrument will turn bank select entirely off. This seems
>> wrong.
>
> Variations are just a different way of using the bank select, so whether
I do understand that variations are one byte of bank select, in disguise,
and which byte it is varies by device.
> the combo is calling itself bank or variation, un-checking the box
> should have the effect of not producing the result called for in the
> box. Un-checking the box leading to bank select turning off sounds
> right to me.
Am I misunderstanding the GUI? I haven't set up variations on my setup
(not sure I can), but the code looks like when variations are possible,
there are two checkboxes involved, bank and variation.
I may not have described the suspicious code well. One flag in Instrument
(m_sendBankSelect) controls whether to send both LSB and MSB. So far
that's not in itself wrong.
The suspicious code is where the variation checkbox and the bank checkbox
both think they control that flag (in slotToggleBank and
slotToggleVariation).
But that flag is really shared. If the checkboxes disagree, the latest
one to be changed wins and controls that flag.
So it looks to me like the variation checkbox can turn m_sendBankSelect
off even if the bank checkbox is still checked. That is what I find
suspicious.
Tom Breton (Tehom)
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122912
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
