I have noticed that under certain conditions a tie displayed in the notation editor will vanish. The notes themselves remain tied, but the tie is no longer visible. The file that I've included with this post demonstrates the issue:
1. Start Rosegarden and load the file "tie_problem.rg." 2. Open the file in the notation editor. 3. Select the note in measure 2. 4. Do something with it (down-arrow, up-arrow). 5. Select the note in measure 3. 6. Notice how one of the ties disappears. 7. Do something with the selected note in 3 (down-arrow, up-arrow). 8. The tie reappears. I've included a patch that corrects the problem. Tim Munro
tie_problem.rg
Description: Binary data
--- src/gui/editors/notation/NotationHLayout.cpp 2013-03-22
09:26:19.000000000 -0700
+++ src/gui/editors/notation/NotationHLayout.cpp 2013-04-06
10:37:05.435447095 -0700
@@ -1840,6 +1840,13 @@
continue;
}
+ // Make a copy of the next event if available.
+ NotationElement *nextNote = note;
+ if (++citr != staff.getViewElementList()->end()) {
+ nextNote = static_cast<NotationElement*>(*citr);
+ }
+ --citr;
+
bool tiedForwards = false;
bool tiedBack = false;
@@ -1875,7 +1882,14 @@
}
if (tiedForwards) {
- note->event()->setMaybe<Int>(m_properties.TIE_LENGTH, 0);
+// note->event()->setMaybe<Int>(m_properties.TIE_LENGTH, 0);
+
+ // Don't modify tie info here, unless the next note has become
+ // something other than a note.
+ if (!nextNote->isNote()) {
+ note->event()->setMaybe<Int>(m_properties.TIE_LENGTH, 0);
+ }
+
tieMap[pitch] = citr;
} else {
note->event()->unset(m_properties.TIE_LENGTH);
------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html
_______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
