I was afraid of something like this. The new code breaks the "interpret
chord names as lead sheet" LilyPond export option.
%{ improper chord: 'C' %} %{ improper chord: 'G' %} %{ improper
chord: 'B' %} %{ improper chord: 'E' %}
That's because you force writing strings like "C" and it is no longer
possible to write chords in LilyPond format.
I've never used this feature, but here's how it works:
http://www.rosegardenmusic.com/tutorials/supplemental/chordnames/
First problem: An existing feature is broken.
Second problem: If it's useful to transpose chord labels, it's useful
to transpose the lead sheet chord labels as well.
Third problem: There are all these hard coded English strings that
can't be translated. It does appear that virtually everybody in the
world can make sense of English chord names. This one is really
complicated.
For instance, I found a Mexican guitar chord site that had a setup
similar to your new chord entry box, and it defaulted to English even
though every bit of text was in Spanish. There was a button to toggle
Spanish names, and this was off by default.
The instructor in those videos I'm watching always uses Spanish chord
names in his lectures.
I'm just a white American guy who has never left the country, so I don't
have a strong opinion on this. I defer to Yves as somebody who is
currently around and natively speaks a language that doesn't use English
note names. Yves: Would you ever want to write chord names in French
in a score? Should we support that?
Fourth problem: I see changes that are consistent with faffing about
with tabs. It looks like some of our files already had tabs, and you
were replacing them with spaces. If so, good job! I want to caution
you against using tabs in new work. Tabs cause no end of stupid
problems, and I hate them.
PROPOSALS
I don't have time to really think this through, but it seems like here
are some ideas:
a) Make your chord writer capable of producing LilyPond format chords.
It's a boon to users who don't have to look up how to write "fis:maj8"
or whatever. Just let the computer do the work. Bonus if you display
them in human.
b) Avoid breaking old files that use legacy stuff.
c) Maybe add a new thing to Event to hold this chord name as an entity
that's easier to work with than an arbitrary text string.
d) Make the human language stuff translatable.
I haven't quite made up my mind whether to commit the patch and work
from there, or insist that you deal with some of these issues before I
can accept it. It mostly depends on how willing you are to hang around
and keep working on it, and what kind of time frame we're looking at.
We're planning a release in about a month. This could get committed in
a branch in the meantime, but not trunk.
I'm willing to help, particularly with the translation nonsense.
If you want commit access, say the word. That was a good hunk of work,
and a great idea. I'm definitely going to work with you to sort through
the problems making this patch unacceptable as it stands.
Alright then, off to bed, and then slogging through another 70 hour
week. Joy.
--
D. Michael McIntyre
------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
