On 04/28/2015 12:11 PM, Tito Latini wrote:
> I think it's ok but perhaps it is better to create a specific folder
> for Rosegarden in QDir::tempPath():
This is definitely a good idea. It's a mess right now as it is.
I would recommend keeping it in the code. E.g. in
DataBlockRepository's ctor (MappedEvent.cpp: 418), we could decide on a
better temp directory name, and create that directory if needed. Put it
in m_tempPath. Then the rest of the member functions would use that
path instead of QDir::tempPath().
>The policy for quit could be
> clear tmpfiles on quit if tmpfiles < 2000
That's an interesting thought. Maybe a new
"DataBlockRepository::fastClear()" that limits itself to no more than
2000 deletes. Or just add a count parameter to the existing clear()
that defaults to -1 (clear all). It could be called in
DataBlockRepository's dtor instead of the close handler. That would
reduce coupling. Something like this:
DataBlockRepository::~DataBlockRepository()
{
// Clear no more than 2000 files to avoid hanging on close.
clear(2000);
}
Ted.
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
