On mercredi 1 mars 2017 01:08:55 CET David Faure wrote:
> presumably it was added for a reason?
OK, git log being much more convenient than svn to figure this out I had a
quick look, and here's the commit that introduced it:
r11067
Author: cannam
Date: Tue Oct 20 11:38:30 2009 +0000
* Fix a further crash on document load. This is probably the crash that
has been troubling Emanuel. The cause was a signal from a parameter box
to the old view -- although the parameter boxes were connected up to the
new view on load, they were still also connected to the old one. Fix:
disconnect them. We're really piling up the fixes here for this gross
little bit of object structure.
If anyone knows how to reproduce this crash, I'm interested.
>From the description it seems to me that the other part of the commit,
+ disconnect(m_segmentParameterBox, 0, oldView, 0);
+ disconnect(m_instrumentParameterBox, 0, oldView, 0);
+ disconnect(m_trackParameterBox, 0, oldView, 0);
... was enough, no need for blockSignals on the view and its children.
--
David Faure, [email protected], http://www.davidfaure.fr
Working on KDE Frameworks 5
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
