2009/7/24 Ralf S. Engelschall <rse+rpm-de...@rpm5.org<rse%2brpm-de...@rpm5.org> >
> On Thu, Jul 23, 2009, Per Ųyvind Karlsen wrote: > > > [...] > > fix va_list autofoo stuff breaking libjs build > > I'm wondering: > > 1. Why is HAVE_VA_LIST_AS_ARRAY defined but never used in the code? it's actually used in jsapi.c, if not defined you'll get warnings like this for linux on x86_64: jsapi.c: In function ‘JS_ConvertArgumentsVA’: jsapi.c:273: warning: passing argument 5 of ‘TryArgumentFormatter’ from incompatible pointer type jsapi.c:135: note: expected ‘struct __va_list_tag (*)[1]’ but argument is of type ‘struct __va_list_tag **’ jsapi.c: In function ‘JS_PushArgumentsVA’: jsapi.c:381: warning: passing argument 5 of ‘TryArgumentFormatter’ from incompatible pointer type jsapi.c:135: note: expected ‘struct __va_list_tag (*)[1]’ but argument is of type ‘struct __va_list_tag **’ I notice yet more mess though, I need to improve this one… > > 2. Why are such changes committed directly to 5.2 and not to HEAD first? mainly because I'm not on HEAD myself ATM, so testing and commiting on rpm-5_2 first obviously makes more sense… -- Regards, Per Øyvind
