There's a segfault here when rindex returns NULL. And POSIX strchr/strrchr, not *BSD index/rindex please.
73 de Jeff On Apr 10, 2011, at 2:05 AM, Per Øyvind Karlsen wrote: > RPM Package Manager, CVS Repository > http://rpm5.org/cvs/ > ____________________________________________________________________________ > > Server: rpm5.org Name: Per Øyvind Karlsen > Root: /v/rpm/cvs Email: pkarl...@rpm5.org > Module: rpm Date: 10-Apr-2011 08:05:40 > Branch: HEAD Handle: 2011041006053900 > > Modified files: > rpm/lib rpmds.c > > Log: > filename must end with '.so' to be a devel(...) dependency > > Summary: > Revision Changes Path > 2.176 +6 -0 rpm/lib/rpmds.c > ____________________________________________________________________________ > > patch -p0 <<'@@ .' > Index: rpm/lib/rpmds.c > ============================================================================ > $ cvs diff -u -r2.175 -r2.176 rpmds.c > --- rpm/lib/rpmds.c 10 Apr 2011 05:54:36 -0000 2.175 > +++ rpm/lib/rpmds.c 10 Apr 2011 06:05:39 -0000 2.176 > @@ -3283,6 +3283,12 @@ > int lnklen; > char path[MAXPATHLEN]; > ARGV_t deps = NULL; > + size_t nb = strlen(fn); > + > + /* Filename must end with ".so" to be devel(...) dependency. */ > + s = rindex(fn, '.'); > + if (strcmp(s, ".so")) > + return 0; > > if ((lnklen = readlink(fn, path, MAXPATHLEN - 1)) == -1) { > warn("%s", fn); > @@ . > ______________________________________________________________________ > RPM Package Manager http://rpm5.org > CVS Sources Repository rpm-...@rpm5.org
smime.p7s
Description: S/MIME cryptographic signature
