On Aug 26, 2013, at 2:25 PM, Per Øyvind Karlsen wrote:
> This patch enables termination of build on duplicate files by setting
> %_duplicate_files_terminate_build .
>
This (and many other patches of yours) merely detect flaws which
all have fairly simple resolutions that could be fully automated,
not just terminating a build, creating a support issue, training
up package monkeys to conform with mysterious distro packaging
policies, etc.
RPM is hard enough to use without creating quality assurance
mechanisms and infrastructure that can be (and often are) disabled
to Get The Job Done.
rpmbuild seemed to be The Right Place to add additional bui9ld
checks, like automating rpmlint. The rationale for augmenting
rpmbuild was to detect problems earlier as part of the complex
processes by which linux distros distribute packages.
The problem with adding additional enforcing quality assurance
checks to rpmbuild is that rpmbuild does not behave the same when
additional checks are enabled/disabled.
There are also no clearly better build process controls around imho. And
that is watching your efforts in ROSA/OMA to improve package quality with
rpmlint
metrics and a score of 50 used as a threshhold rejection criteria.
Instead, all that happens is that a support issue, and a frequently asked
question,
is created
How do I disable these checks?
The better approach (for simple problems like duplicate files) is to implement
a resolution mechanism. There are certainly no consequences (which is
why duplicate files is implemented as a warning, not an error, where this
patch just adds FULLSTOP configurable rejection criteria to rpmbuild that
is specific to distros and cannot be generally enabled/distributed with rpm).
There is also no reason whatsoever why automation on %files manifests cannot
be undertaken outside of rpmbuild using "rpm -qlvp" markup to mass change
entire distro build recipes. Adding patches to rpmbuild which are normally
disabled in distributed rpm releases just delays, not enhances, existing
distro build systems).
73 de Jeff
> --
> Regards,
> Per Øyvind
> <rpm-5.4.10-duplicate_files_terminate_build.patch>
______________________________________________________________________
RPM Package Manager http://rpm5.org
Developer Communication List rpm-devel@rpm5.org
