ffesti requested changes on this pull request.
Other than the bit sloppy RE this looks good.
> if not dist.py_version:
- warn("Version for {!r} has not been found".format(dist),
RuntimeWarning)
- continue
+ # Try to parse the Python version from the path the metadata
+ # resides at (e.g. /usr/lib/pythonX.Y/site-packages/...)
+ import re
+ res = re.search("/python(?P<pyver>[0-9.]{3})/", path_item)
Can you please use a more precise RE pattern . E.g.
\\d\\.\\d or [0-9]\\.[0-9] instead of
[0-9.]{3}
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/154#pullrequestreview-21972479_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
