Do you have measurements of the effect of fsync()?
The last time sync/fdatasync were suggested for RPM that I am aware of was
~2011 in Mandriva. The issue comes up every few years this century ...
Here was the effect of adding fsync/fdatasync to RPM, measure on otherwise
identical system with a package with lots of files:
`
/* Measurements from installing kernel-source package:
* +fsync
* total: 1 0.000000 MB 640.854524 secs
* +fdatasync
* total: 1 0.000000 MB 419.983200 secs
* w/o fsync/fdsatasync:
* total: 1 0.000000 MB 12.492918 secs
*/
xx = fsync(Fileno(fsm->wfd));
`
Yes this was rotating DSADI, not SSD.
BTW, the right place to patch isn't Fclose(), which is one of the more subtle
(or hacked, YMMV) pieces of code in RPM. Instead, do the sync before closing
the FD_t in lib/fsm.c (or whatever replaces).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/187#issuecomment-291632032_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
