> Looks good and pretty straight forward. May be should get a test case.
Yep. I actually have a test-case written in the form of "plugin development"
test, but it needs some cmake infra bits first. But, this PR isn't in any
particular hurry.
> It might also be a good idea to point out in the docs that these are called
> even when running without --root. Technically we omit the chroot call in this
> case but the hooks are ofc executed no matter what (as they should be)
Um, no they don't. rpmChrootIn() and rpmChrootOut() do always get called but
they return with a no-op from the first condition.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2669#issuecomment-1732976149
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2669/c1732976...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
