@pmatilai commented on this pull request.
> + rpmRC rc = RPMRC_FAIL;
+
+ /* XXX Skip valid arch check if not building binary package */
+ if (!(spec->flags & RPMSPEC_ANYARCH) && checkForValidArchitectures(spec)) {
+ goto exit;
+ }
+
+ fillOutMainPackage(spec->packages->header);
+ /* Define group tag to something when group is undefined in main package*/
+ if (!headerIsEntry(spec->packages->header, RPMTAG_GROUP)) {
+ headerPutString(spec->packages->header, RPMTAG_GROUP, "Unspecified");
+ }
+
+ char *platform = rpmExpand("%{_target_platform}", NULL);
+ char *os = rpmExpand("%{_target_os}", NULL);
+ char *optflags = rpmExpand("%{optflags}", NULL);
The reason these aren't showing up in CI is that CI is built without any
optimizations.
Need to tweak that a bit...
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2646#discussion_r1352328930
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2646/review/1667440...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
