@Conan-Kudo requested changes on this pull request.
> @@ -17,6 +17,7 @@ target_link_libraries(rpmlua PRIVATE LUA::LUA)
target_link_libraries(rpmbuild PRIVATE librpmbuild)
target_link_libraries(rpmspec PRIVATE librpmbuild)
target_link_libraries(rpmdeps PRIVATE librpmbuild)
+target_link_libraries(rpmuncompress PRIVATE archive)
Is this the name of the dependency? It looks like it's `LIBARCHIVE` instead of
`archive`.
> @@ -509,6 +509,9 @@ can just create the directory. It accepts a number of
> options:
-n DIR set the name of build directory (default is `%{name}-%{version}`)
-T skip the default unpacking of the first source (used with
`-a` or `-b`)
+-p ensures that the sources will be in the default build directory,
How would this be exposed in `%autosetup`? We can't use `-p` there since that's
for patchlevel passed to `patch`. Maybe instead use `-C` and describe it as
`Create the build directory and ensure the archive contents are unpacked there,
stripping the top level directory in the archive if it exists`.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2859#pullrequestreview-1832404055
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2859/review/1832404...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
