https://bugzilla.samba.org/show_bug.cgi?id=10037
Summary: do_mknod fails to create socket file
Product: rsync
Version: 3.0.9
Platform: All
OS/Version: Solaris
Status: NEW
Severity: normal
Priority: P5
Component: core
AssignedTo: way...@samba.org
ReportedBy: simon.klink...@gmail.com
QAContact: rsync...@samba.org
Created attachment 9065
--> https://bugzilla.samba.org/attachment.cgi?id=9065
mknod patch file
Hi,
I'm observing a strange problem with rsync on Solaris/Illumos.
My command
rsync -rlHpogt -T /tmp --block-size=4096 --inplace --delete --checksum
--no-whole-file --specials /var/data /var/data2
results into this error message (truncated path):
error: mknod "/var/data2/<many directories>/socketfile" failed: No such file or
directory (2)
error: some files/attrs were not transferred (see previous errors) (code 23) at
main.c(1052) [sender=3.0.9]
After lots of debugging I found out, that do_mknod() wants to create a socket
file. The given variable pathname contains a 127 characters path (with many
directories).
Now consider this line in do_mknod:
strlcpy(saddr.sun_path, pathname, sizeof saddr.sun_path);
It copies pathname into sun_path without any length checking. The function
strlcpy truncates in my case the path because sun_path is limited to 108
characters on at least Solaris/Illumos. Maybe this is a problem on Linux as
well (see also:
http://www.kernelsources.org/source/xref/illumos-gate/usr/src/uts/common/sys/un.h#55
and for Linux
http://www.kernelsources.org/source/xref/linux/include/uapi/linux/un.h#10). The
bind() call succeeds (to be honest, I don't really know why. Probably the
truncated path exists as well) and then do_mknod() calls do_chmod() for the
full path… which fails with ENOENT. I tested it with rsync 3.0.7 and 3.0.9 with
the same result.
I attached a little patch with a workaround which seems to be working (for me).
Basically, I do a chdir() to step into the deepest directory of pathname to
keep the path as short as possible and after bind() I step back into the
previous directory.
I guess there are better ways to fix this, but maybe somebody will help this
quick workaround.
Thanks,
Simon Klinkert
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
