The branch, master has been updated
       via  7470b9b smbc_opendir should not return EEXIST with invalid login 
credentials
      from  de5e23c python: tests: Add tests for samba.posix_eadb module

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 7470b9b18af282a742929d3fc90f4be5520428a1
Author: David Mulder <dmul...@suse.com>
Date:   Thu Nov 2 08:25:11 2017 -0600

    smbc_opendir should not return EEXIST with invalid login credentials
    
    Signed-off-by: David Mulder <dmul...@suse.com>
    
    Reviewed-by: Andreas Schneider <a...@samba.org>
    Reviewed-by: Jim McDonough <j...@samba.org>
    
    Autobuild-User(master): Jim McDonough <j...@samba.org>
    Autobuild-Date(master): Thu Nov  9 01:49:06 CET 2017 on sn-devel-144

-----------------------------------------------------------------------

Summary of changes:
 source3/libsmb/libsmb_server.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/libsmb/libsmb_server.c b/source3/libsmb/libsmb_server.c
index b0e5926..93b9e80 100644
--- a/source3/libsmb/libsmb_server.c
+++ b/source3/libsmb/libsmb_server.c
@@ -351,8 +351,8 @@ SMBC_server_internal(TALLOC_CTX *ctx,
                                                  "?????",
                                                  *pp_password);
                        if (!NT_STATUS_IS_OK(status)) {
-                                errno = map_errno_from_nt_status(status);
                                 cli_shutdown(srv->cli);
+                                errno = map_errno_from_nt_status(status);
                                srv->cli = NULL;
                                 
smbc_getFunctionRemoveCachedServer(context)(context,
                                                                             
srv);
@@ -562,8 +562,8 @@ SMBC_server_internal(TALLOC_CTX *ctx,
 
        status = cli_tree_connect_creds(c, share, "?????", creds);
        if (!NT_STATUS_IS_OK(status)) {
-               errno = map_errno_from_nt_status(status);
                cli_shutdown(c);
+               errno = map_errno_from_nt_status(status);
                return NULL;
        }
 


-- 
Samba Shared Repository

Reply via email to