On Fri, 2013-06-21 at 05:58 +0000, philippe.simo...@swisscom.com wrote:
> Hi Andrew,
>
> many thanks for you patch,
> i tested it on 2 different systems but without success (the crash is always
> happening).
>
> before applying the patch, I had a strange problem : I couldn't reproduce
> the problem (with wbinfo --uid-info 3000000)
> on one of the machine. no chance even if I reinstall, re-provision, ...). I
> finally reboot the machine and after the reboot the crash
> was reproduceable again (...)
Thank you for finally getting back to me on this. After seeing it once,
I was also unable to reproduce the crash, and so was patching blind.
This remains illusive.
Does this alternative patch help?
> on both machines, what I've done :
> (...untar...)
> cd samba-4.0.6
> patch -p1 < 0001-s4-winbind-Add-special-case-for-BUILTIN-domain.patch
> ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --enable-fhs
> make
> make install
> rm /etc/samba/smb.conf
> samba-tool domain provision --dns-backend=BIND9_FLATFILE --server-role=dc
> --realm TEST.CH --domain TEST --adminpass=Pa$$w0rd
> samba -i -M single
>
> and ->>> wbinfo --uid-info 3000000
>
> I get :
> ---------------------
> samba version 4.0.6 started.
> Copyright Andrew Tridgell and the Samba Team 1992-2012
> samba: using 'single' process model
> Attempting to autogenerate TLS self-signed keys for https for hostname
> 'WZ3.test3.ch'
> TLS self-signed keys generated OK
> ===============================================================
> INTERNAL ERROR: Signal 11 in pid 4844 (4.0.6)
> Please read the Trouble-Shooting section of the Samba HOWTO
> ===============================================================
> PANIC: internal error
> Aborted
> ---------------------
>
> Best regards
>
> Philippe
Thanks,
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
>From 213dd8c754e381fcca0bc692422189fb0a9fa9d6 Mon Sep 17 00:00:00 2001
From: Andrew Bartlett <abart...@samba.org>
Date: Sat, 15 Jun 2013 19:54:14 +1000
Subject: [PATCH] gensec: work around nested event loops by ensuring that the
gensec_security remains valid
Some nested event loops cause the main context varible here to become
deallocated. This ensures that cannot happen until the end of the
call.
Andrew Bartlett
---
auth/gensec/gensec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/auth/gensec/gensec.c b/auth/gensec/gensec.c
index ea62861..ad6a19d 100644
--- a/auth/gensec/gensec.c
+++ b/auth/gensec/gensec.c
@@ -216,9 +216,11 @@ _PUBLIC_ NTSTATUS gensec_update(struct gensec_security *gensec_security, TALLOC_
const DATA_BLOB in, DATA_BLOB *out)
{
NTSTATUS status;
-
+ TALLOC_CTX *mem_ctx = talloc_new(NULL);
+ talloc_reference(mem_ctx, gensec_security);
status = gensec_security->ops->update(gensec_security, out_mem_ctx,
ev, in, out);
+ talloc_free(mem_ctx);
if (!NT_STATUS_IS_OK(status)) {
return status;
}
--
1.7.11.7
--
To unsubscribe from this list go to the following URL and read the
instructions: https://lists.samba.org/mailman/options/samba
