On Tue, Apr 09, 2024 at 11:20:14AM -0400, Kevin O'Connor wrote:
> Introduce stdvga_dac_read_many() and stdvga_dac_write_many() for
> writing multiple dac palette entries.  Convert the stdvga_dac_read()
> and stdvga_dac_write() low-level IO access functions in stdvgaio.c to
> access just one color palette entry.
> 
> Signed-off-by: Kevin O'Connor <ke...@koconnor.net>
> --
> 
> There should not be any functional change resulting from this patch.
> However, during mode switches (and a few other rare calls) there will
> likely be a few more outb() calls due to additional writes to the dac
> index register.  In theory this could adversely impact performance,
> but in practice I think it is unlikely it will be noticeable.  The
> original code was also not optimized (it already makes a large number
> of redundant writes to the dac index register), and performance
> sensitve code already avoids using the vgabios.

I committed this change.

-Kevin
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org

Reply via email to