incoming/1296 proposed bug fix
Folks:
I've looked into bug #1296, and found that it seems to be due to the fact
that the code in placement.c is inconsistent on whether it expects PageTop
and PageBottom to incorporate pdeltay (and likewise for Page{Left,Right}
and pdeltax).
Here's a proposed patch:
cut here
--- fvwm-2.5.10/fvwm/placement.c.orig 2004-03-17 08:57:50.0 -0800
+++ fvwm-2.5.10/fvwm/placement.c2004-08-18 20:58:12.0 -0700
@@ -280,7 +280,7 @@
{
test_y +=1;
}
- } /* while */
+ } /* for */
if (loc_ok == False)
{
return False;
@@ -873,8 +873,8 @@
rc = False;
PageLeft = screen_g.x - pdeltax;
PageTop= screen_g.y - pdeltay;
- PageRight = PageLeft + screen_g.width - pdeltax;
- PageBottom = PageTop + screen_g.height - pdeltay;
+ PageRight = PageLeft + screen_g.width;
+ PageBottom = PageTop + screen_g.height;
xl = -1;
yt = PageTop;
/* override if Manual placement happen */
@@ -1016,8 +1016,8 @@
{
Scr.cascade_y = 2 * fw-title_thickness;
}
- attr_g-x = Scr.cascade_x + PageLeft - pdeltax;
- attr_g-y = Scr.cascade_y + PageTop - pdeltay;
+ attr_g-x = Scr.cascade_x + PageLeft;
+ attr_g-y = Scr.cascade_y + PageTop;
/* try to keep the window on the screen */
get_window_borders(fw, b);
if (attr_g-x + fw-frame_g.width = PageRight)
cut here
I haven't checked whether there are any similar errors elsewhere in
fvwm (I'm not that familiar with the code). But, this does it for me.
--Paul Vojta, [EMAIL PROTECTED]
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]
CVS domivogt: * Committed fix for #1296.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: domivogt04/08/19 14:56:30 Modified files: . : ChangeLog fvwm : placement.c Log message: * Committed fix for #1296. -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: incoming/1296 proposed bug fix
On Thu, Aug 19, 2004 at 12:01:56AM -0700, Paul Vojta wrote:
I've looked into bug #1296, and found that it seems to be due to the fact
that the code in placement.c is inconsistent on whether it expects PageTop
and PageBottom to incorporate pdeltay (and likewise for Page{Left,Right}
and pdeltax).
The old code indeed looks broken. I will commit your patch
shortly. Thanks for your help.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt, [EMAIL PROTECTED]
Reply-To: [EMAIL PROTECTED]
pgpxqJZmwCc8Y.pgp
Description: PGP signature
Notification: incoming/1403
FVWM Bug Tracking notification new message incoming/1403 Message summary for PR#1403 From: [EMAIL PROTECTED] Subject: Process crashes Date: Wed, 18 Aug 2004 22:03:53 -0500 0 replies 0 followups ORIGINAL MESSAGE FOLLOWS From [EMAIL PROTECTED] Wed Aug 18 22:03:53 2004 Received: from util7.math.uh.edu ([129.7.128.5]) by util2.math.uh.edu with esmtp (Exim 4.30) id 1BxdDV-0007Gd-Fw for [EMAIL PROTECTED]; Wed, 18 Aug 2004 22:03:53 -0500 Received: from localhost (util7.math.uh.edu [127.0.0.1]) by util7.math.uh.edu (8.12.11/8.12.5) with ESMTP id i7J33rIP016322 for [EMAIL PROTECTED]; Wed, 18 Aug 2004 22:03:53 -0500 Date: Wed, 18 Aug 2004 22:03:53 -0500 Message-Id: [EMAIL PROTECTED] From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Process crashes Full_Name: Dave Roberts Version: 2.5.10-r3 CVS_Date: OS: Gentoo 2.6.6 kernel X_Server: xfree-4.3.0-r6 Submission from: (NULL) (68.233.161.27) When using Mozilla Firefox, sometimes when I close the extensions window all of Firefox will close (crash). Sometimes when I close an IM window using gaim, the entire program will close (crash). This leads me to believe that FVWM is crashing these applications in the same way. Their is no clear way to reproduce it, but it happens fairly often. Please let me know what I can do to help. -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: Notification: incoming/1403
On Wed, Aug 18, 2004 at 10:03:54PM -0500, [EMAIL PROTECTED] wrote: When using Mozilla Firefox, sometimes when I close the extensions window all of Firefox will close (crash). Sometimes when I close an IM window using gaim, the entire program will close (crash). This leads me to believe that FVWM is crashing these applications in the same way. Their is no clear way to reproduce it, but it happens fairly often. Please let me know what I can do to help. Well, you can start by launching these applications from within an Xterm or whatever to see what output is produced. Also, if you have one, you can tail -f ~/.xsession-errors to see what FVWM spits out (if anything) when these applications crash. -- Thomas Adam -- Frankly, Mr. Shankly, since you ask. You are a flatulent pain in the arse. -- Morrissey. -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
