Problems building snap-20040826
P AUTHORS P ChangeLog P acconfig.h cvs update: warning: configure.in was lost U configure.in P fvwm/events.c P libs/FScreen.c acinclude.m4:7: warning: underquoted definition of AC_FUNC_SELECT run info '(automake)Extending aclocal' or see http://sources.redhat.com/automake/automake.html#Extending%20aclocal acinclude.m4:87: warning: underquoted definition of pds_CHECK_TYPE acinclude.m4:126: warning: underquoted definition of smr_SWITCH acinclude.m4:171: warning: underquoted definition of smr_ARG_WITHLIB acinclude.m4:218: warning: underquoted definition of smr_ARG_WITHINCLUDES acinclude.m4:259: warning: underquoted definition of smr_CHECK_LIB acinclude.m4:303: warning: underquoted definition of mg_DEFINE_IF_NOT acinclude.m4:332: warning: underquoted definition of AM_PATH_GTK acinclude.m4:525: warning: underquoted definition of AM_PATH_IMLIB acinclude.m4:664: warning: underquoted definition of AM_PATH_GDK_IMLIB acinclude.m4:1010: warning: underquoted definition of AM_CHECK_PKG_CONFIG acinclude.m4:1043: warning: underquoted definition of AM_CHECK_FT2 acinclude.m4:1178: warning: underquoted definition of AM_CHECK_FC acinclude.m4:1334: warning: underquoted definition of AM_CHECK_XFT /usr/share/aclocal/vorbis.m4:9: warning: underquoted definition of XIPH_PATH_VORBIS /usr/share/aclocal/pkg.m4:5: warning: underquoted definition of PKG_CHECK_MODULES /usr/share/aclocal/ogg.m4:8: warning: underquoted definition of XIPH_PATH_OGG /usr/share/aclocal/libole2.m4:18: warning: underquoted definition of AM_PATH_LIBOLE2 /usr/share/aclocal/libmikmod.m4:11: warning: underquoted definition of AM_PATH_LIBMIKMOD /usr/share/aclocal/audiofile.m4:12: warning: underquoted definition of AM_PATH_AUDIOFILE acinclude.m4:7: warning: underquoted definition of AC_FUNC_SELECT run info '(automake)Extending aclocal' or see http://sources.redhat.com/automake/automake.html#Extending%20aclocal acinclude.m4:87: warning: underquoted definition of pds_CHECK_TYPE acinclude.m4:126: warning: underquoted definition of smr_SWITCH acinclude.m4:171: warning: underquoted definition of smr_ARG_WITHLIB acinclude.m4:218: warning: underquoted definition of smr_ARG_WITHINCLUDES acinclude.m4:259: warning: underquoted definition of smr_CHECK_LIB acinclude.m4:303: warning: underquoted definition of mg_DEFINE_IF_NOT acinclude.m4:332: warning: underquoted definition of AM_PATH_GTK acinclude.m4:525: warning: underquoted definition of AM_PATH_IMLIB acinclude.m4:664: warning: underquoted definition of AM_PATH_GDK_IMLIB acinclude.m4:1010: warning: underquoted definition of AM_CHECK_PKG_CONFIG acinclude.m4:1043: warning: underquoted definition of AM_CHECK_FT2 acinclude.m4:1178: warning: underquoted definition of AM_CHECK_FC acinclude.m4:1334: warning: underquoted definition of AM_CHECK_XFT /usr/share/aclocal/vorbis.m4:9: warning: underquoted definition of XIPH_PATH_VORBIS /usr/share/aclocal/pkg.m4:5: warning: underquoted definition of PKG_CHECK_MODULES /usr/share/aclocal/ogg.m4:8: warning: underquoted definition of XIPH_PATH_OGG /usr/share/aclocal/libole2.m4:18: warning: underquoted definition of AM_PATH_LIBOLE2 /usr/share/aclocal/libmikmod.m4:11: warning: underquoted definition of AM_PATH_LIBMIKMOD /usr/share/aclocal/audiofile.m4:12: warning: underquoted definition of AM_PATH_AUDIOFILE autoheader: WARNING: Using auxiliary files such as `acconfig.h', `config.h.bot' autoheader: WARNING: and `config.h.top', to define templates for `config.h.in' autoheader: WARNING: is deprecated and discouraged. autoheader: autoheader: WARNING: Using the third argument of `AC_DEFINE' and autoheader: WARNING: `AC_DEFINE_UNQUOTED' allows to define a template without autoheader: WARNING: `acconfig.h': autoheader: autoheader: WARNING: AC_DEFINE([NEED_FUNC_MAIN], 1, autoheader: [Define if a function `main' is needed.]) autoheader: autoheader: WARNING: More sophisticated templates can also be produced, see the autoheader: WARNING: documentation. checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for gawk... gawk checking whether make sets $(MAKE)... yes checking whether to enable command logging... no checking whether to enable debugging messages... no checking imagepath... /usr/include/X11/bitmaps:/usr/include/X11/pixmaps checking for gcc... gcc checking for C compiler default output file name... a.out checking whether the C compiler works... yes checking whether we are cross compiling... no checking for suffix of executables... checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ANSI C... none needed checking for style of include used by make... GNU checking dependency style of gcc... gcc3 checking how to run the C preprocessor... gcc -E checking for library containing strerror... none required checking for egrep... grep -E checking for ANSI C header files... yes checking for
Re: FvwmTaskBar Maildir patch
On Thu, Aug 19, 2004 at 11:57:21PM -0400, Jim C. Brown wrote: On Wed, Aug 04, 2004 at 12:25:39PM +0200, Dominik Vogt wrote: I don't feel confortable playing around with the Makefiles so I just added #define USE_MAILDIR at the top of Goodies.c (I'm hoping that someone who knows more can do this right). Using compile time configuration in general and #ifdef in particular is not the right way in fvwm. Every feature has to be configurable at run time. Here is what I would do: - Add a new config variable, e.g. MailDir - Add a flag that indicates whether MailBox or MailDir is used. - Split the __cool_get_inboxstatus() function into two sub functions __cool_get_inboxstatus_mailbox() and cool_get_inboxstatus_maildir() and call one of them from cool_get_inboxstatus() according to the flag state. Done. Set *FvwmTaskBar: MailDir in the config file to toggle the flag. I'd like to commit the patch, but I have a few questions/requests first. * Is it *guaranteed* that /new and /cur are the proper subdirectory names? Or is there any chance the user can configure these names? * You can safely remove the comments /* forgot this bit of garbage-cleaning in the original patch */ * Comments with // can not be used as this is not allowed in the C89 standard. * Can you please add an entry to the man page, the AUTHORS and the modules/ChangeLog file? * I'm afraid of using the scandir() and alphasort() functions. According to the man page, these are non-standard funtions that come from BSD 4.3. I guess they are not available on many systems. Can the code be written without them? I considered adding Postfix-style detection (checking for the '/' at the end of the filename). I can't decide which of the two is the better idea, so I decided to attach both versions. I'd use a separate config option. I think it is less confusing. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] pgpuTSuO1vjH3.pgp Description: PGP signature
CVS domivogt: * Fixed Solaris Xinerama configure test (nested AC_CHECK_LIB calls don't work)
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: domivogt04/08/26 04:40:42 Modified files: . : ChangeLog NEWS configure.in libs : FScreen.c Log message: * Fixed Solaris Xinerama configure test (nested AC_CHECK_LIB calls don't work) * Cleaned up the ifdef hell in FScreen.c; all code is compiled all the time; please don't put code in ifdefs. -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: Problems building snap-20040826
On Thu, Aug 26, 2004 at 03:00:52AM -0500, Jason L Tibbitts III wrote: ./configure: line 6056: syntax error near unexpected token `newline' ./configure: line 6056: ` yes:no:' I hope this is fixed now. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] pgp2g20hr6pCP.pgp Description: PGP signature
Re: Solaris Xinerama support
On Fri, Aug 20, 2004 at 09:32:35AM -0400, Chris Ross wrote: Dan Espen wrote: If the #define'd stuff is only used on Solaris, when the header isn't there, and the library support is there, I'd say that was OK. Yup. That's how it's done. Only if the libXinerama stuff isn't found will it look for Solaris' calls, and only if those are found will it look for the header. If the header is found, the few lines (to replace the header) I added don't get used. The following should be the full diff against CVS HEAD for this patch. Thanks for all your help! - Chris Index: configure.in === RCS file: /home/cvs/fvwm/fvwm/configure.in,v retrieving revision 1.294 diff -u -u -r1.294 configure.in --- configure.in 23 May 2004 16:20:23 - 1.294 +++ configure.in 20 Aug 2004 13:26:58 - @@ -298,8 +298,18 @@ $UNSET ac_cv_lib_Xinerama_XineramaIsActive AC_CHECK_LIB(Xinerama, XineramaIsActive, with_xinerama=yes; Xinerama_LIBS=-lXinerama; AC_DEFINE(HAVE_XINERAMA), +AC_CHECK_LIB(Xext, XineramaGetState, + [ AC_DEFINE(HAVE_XINERAMA) AC_DEFINE(HAVE_SOLARIS_XINERAMA) + with_xinerama=yes; Xinerama_LIBS=-lXext + my_CPPFLAGS=$CPPFLAGS; CPPFLAGS=$X_CPPFLAGS $CPPFLAGS + my_hdr=X11/extensions/xinerama.h + AC_CHECK_HEADER($my_hdr, AC_DEFINE(HAVE_SOLARIS_XINERAMA_H) + problem_xinerama= (Using Solaris Xinerama calls), + problem_xinerama= (Failed to find Sun's $my_hdr)) + CPPFLAGS=$my_CPPFLAGS], with_xinerama=no; Xinerama_LIBS= problem_xinerama=: Failed to detect libXinerama, +[$X_LIBS $X_PRE_LIBS -lX11 $X_EXTRA_LIBS]), [$X_LIBS $X_PRE_LIBS -lXext -lX11 $X_EXTRA_LIBS]) fi AC_SUBST(Xinerama_LIBS) Note that this nesting of AC_CHECK_LIB calls did not work with my autoconf/automake versions. I have split it in two separate calls. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] pgpNYa7L80UQF.pgp Description: PGP signature
Re: Solaris Xinerama support
Dominik Vogt [EMAIL PROTECTED] writes: Note that this nesting of AC_CHECK_LIB calls did not work with my autoconf/automake versions. I have split it in two separate calls. Darn. And I tested this on Linux and Solaris. I woke up in the middle of the night and it dawned on me that I never updated NEWS. I figured no one would notice and I could take care of it when I got up. -- Dan Espen E-mail: [EMAIL PROTECTED] -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: Solaris Xinerama support
On Thu, Aug 26, 2004 at 06:48:22AM -0400, Dan Espen wrote: I woke up in the middle of the night and it dawned on me that I never updated NEWS. I figured no one would notice and I could take care of it when I got up. Heh, now *that*'s what I call being passionate about one's work. :) -- Thomas Adam -- Quis custodiet ipsos custodes? -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: Solaris Xinerama support
On Thu, Aug 26, 2004 at 06:48:22AM -0400, Dan Espen wrote: Dominik Vogt [EMAIL PROTECTED] writes: Note that this nesting of AC_CHECK_LIB calls did not work with my autoconf/automake versions. I have split it in two separate calls. Darn. And I tested this on Linux and Solaris. They changed something with quoting in autoconf/automake a while ago. Unfortunately you have to test with the old and new auto* versions to make sure some things in configure work fine. I woke up in the middle of the night and it dawned on me that I never updated NEWS. I figured no one would notice and I could take care of it when I got up. If all else fails, I will notice missing NEWS entries sooner or later ;-) Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] pgpbpOM2yel87.pgp Description: PGP signature
Re: Problems building snap-20040826
DV == Dominik Vogt [EMAIL PROTECTED] writes: DV I hope this is fixed now. I pushed another snapshot. - J -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: Solaris Xinerama support
Thanks Dominik. Dominik Vogt wrote: They changed something with quoting in autoconf/automake a while ago. Unfortunately you have to test with the old and new auto* versions to make sure some things in configure work fine. Odd. It worked for me, too, using the same version of autoconf that'd previously generated the configure. Guess that must've changed on your system and not mine. Thanks for fixing it! There were a couple issues with your changes to libs/FScreen.c. I don't know that I agree with the all code should be compiled opinion, but that's certainly your call to make. And the #ifdef'd code is now more sensible than it was, and than I'd made it. Thanks. But, there was one typo (capitalization error), and one error in the #def's. Solaris' xinerama.h does *not* define XineramaScreenInfo, since Solaris' xinerama system API is *completely* different. I just moved the relevant #def out one level. A patch to libs/FScreen.c is attached. It will now link both with and without the Solaris xinerama.h header. Thanks again! - Chris Index: libs/FScreen.c === RCS file: /home/cvs/fvwm/fvwm/libs/FScreen.c,v retrieving revision 1.24 diff -u -r1.24 FScreen.c --- libs/FScreen.c 26 Aug 2004 09:40:42 - 1.24 +++ libs/FScreen.c 26 Aug 2004 15:52:53 - @@ -73,10 +73,10 @@ # define FScreenHaveXinerama 1 # ifdef HAVE_SOLARIS_XINERAMA # define FScreenHaveSolarisXinerama 1 +# define FSCREEN_NEED_SCREENINFO # ifdef HAVE_SOLARIS_XINERAMA_H # include X11/extensions/xinerama.h # else -# define FSCREEN_NEED_SCREENINFO # define FSCREEN_NEED_SOLARIS_PROTOTYPES # endif # else @@ -114,7 +114,7 @@ #if FScreenHaveXinerama # if FScreenHaveSolarisXinerama # define XineramaQueryExtension(d,b,c) 1 /* Lie, for now */ -# define XineramaIsActive(d) Xineramagetstate((d),0) +# define XineramaIsActive(d) XineramaGetState((d),0) # endif #else # define XineramaQueryExtension(da, b, c) 0
configure extra cflags?
Hey there. I have a small problem, that will require changes to configure to solve. On my Solaris machine, there are #pragma's in some of the openwin X headers that gcc (3.3.2) doesn't like. This is easily solvable with -wunknown-pragmas, but if I put that in CFLAGS on the configure command-line environment, it will append -Wall, thus cancelling it out. I thought it might be more useful to be able to put arbitrary things on the CFLAGS (and/or CPPFLAGS), but have them go after the -Wall. Anyone else have any thoughts on this issue? - Chris -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Patch for placing windows under the mouse
Hi everyone,
I did not feal comfortable with any of the provided window placement
methods. I would like the windows to appear where the mouse pointer is
because this is the place my eyes are concentrating on.
Even ManualPlacement is one click too much.
The patch allows you to put Style * MousePlacement into your .fvwm2rc
and you will never have to turn your head again when a new window shows
up.
diff -ru fvwm-2.5.10/fvwm/fvwm.h fvwm-2.5.10-pepe/fvwm/fvwm.h
--- fvwm-2.5.10/fvwm/fvwm.h 2004-02-16 14:45:59.0 +0100
+++ fvwm-2.5.10-pepe/fvwm/fvwm.h2004-08-27 00:12:11.633285840 +0200
@@ -467,8 +467,9 @@
#define PLACE_TILECASCADE 0x5
#define PLACE_CASCADE_B 0x6
#define PLACE_MINOVERLAP0x7
-#define PLACE_MASK 0x7
- unsigned placement_mode : 3;
+#define PLACE_MOUSE0x8
+#define PLACE_MASK 0xF
+ unsigned placement_mode : 4;
unsigned ewmh_placement_mode : 2; /* see ewmh.h */
#define WS_CR_MOTION_METHOD_AUTO CR_MOTION_METHOD_AUTO
#define WS_CR_MOTION_METHOD_USE_GRAV CR_MOTION_METHOD_USE_GRAV
diff -ru fvwm-2.5.10/fvwm/placement.c fvwm-2.5.10-pepe/fvwm/placement.c
--- fvwm-2.5.10/fvwm/placement.c2004-03-17 17:57:50.0 +0100
+++ fvwm-2.5.10-pepe/fvwm/placement.c 2004-08-26 23:31:00.0 +0200
@@ -984,6 +984,13 @@
fw, sflags, screen_g, xl, yt, pdeltax, pdeltay, 1);
flags.is_smartly_placed = True;
break;
+ case PLACE_MOUSE:
+ if (False != FQueryPointer(dpy, Scr.Root, JunkRoot, JunkChild,
+ attr_g-x, attr_g-y, JunkX, JunkY, JunkMask))
+ {
+ break;
+ }
+ /* fall through to tilecascade placement */
case PLACE_TILECASCADE:
flags.is_smartly_placed = SmartPlacement(
fw, screen_g, fw-frame_g.width, fw-frame_g.height,
diff -ru fvwm-2.5.10/fvwm/style.c fvwm-2.5.10-pepe/fvwm/style.c
--- fvwm-2.5.10/fvwm/style.c2004-02-16 14:45:59.0 +0100
+++ fvwm-2.5.10-pepe/fvwm/style.c 2004-08-26 23:34:29.0 +0200
@@ -3087,6 +3087,12 @@
FPS_RAISE_UNFOCUSED_CLIENT_CLICK(
S_FOCUS_POLICY(SCC(*ps)), 1);
}
+ else if (StrEquals(token, MousePlacement))
+ {
+ ps-flags.placement_mode = PLACE_MOUSE;
+ ps-flag_mask.placement_mode = PLACE_MASK;
+ ps-change_mask.placement_mode = PLACE_MASK;
+ }
else if (StrEquals(token, MaxWindowSize))
{
int val1;
Regards,
Christoph
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]
CVS dane: * libs/FScreen.c: Fixed case error. Patch from Chris Ross.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: dane04/08/26 19:05:05 Modified files: . : ChangeLog Log message: * libs/FScreen.c: Fixed case error. Patch from Chris Ross. -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: configure extra cflags?
Chris Ross [EMAIL PROTECTED] writes: Hey there. I have a small problem, that will require changes to configure to solve. On my Solaris machine, there are #pragma's in some of the openwin X headers that gcc (3.3.2) doesn't like. This is easily solvable with -wunknown-pragmas, but if I put that in CFLAGS on the configure command-line environment, it will append -Wall, thus cancelling it out. I thought it might be more useful to be able to put arbitrary things on the CFLAGS (and/or CPPFLAGS), but have them go after the -Wall. Anyone else have any thoughts on this issue? If I understand the question, I'd ifdef in the pragmas, only when the sun compiler is being used. -- Dan Espen E-mail: [EMAIL PROTECTED] -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: Patch for placing windows under the mouse
On 27 Aug 2004 01:39:04 +0200, Christoph Bussenius wrote: I did not feal comfortable with any of the provided window placement methods. I would like the windows to appear where the mouse pointer is because this is the place my eyes are concentrating on. Even ManualPlacement is one click too much. The patch allows you to put Style * MousePlacement into your .fvwm2rc and you will never have to turn your head again when a new window shows up. I think UnderCursorPlacement is a more intuitive name. MousePlacement sounds like ManualPlacement using the mouse. todo-3.0 also mentions UnderCursorPlacementOffset. Or maybe the algorithm should be to center a window under the cursor, but have it fully visible if possible. You should also patch at least the man page (and ChangeLog, NEWS). Regards, Mikhael. -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: configure extra cflags?
On Thu, Aug 26, 2004 at 08:11:23PM -0400, Dan Espen wrote: Chris Ross [EMAIL PROTECTED] writes: Hey there. I have a small problem, that will require changes to configure to solve. On my Solaris machine, there are #pragma's in some of the openwin X headers that gcc (3.3.2) doesn't like. This is easily solvable with -wunknown-pragmas, but if I put that in CFLAGS on the configure command-line environment, it will append -Wall, thus cancelling it out. If I understand the question, I'd ifdef in the pragmas, only when the sun compiler is being used. At least on my Solaris boxes, #pragma ident is the only pragma in /usr/openwin/include. Gcc (3.3.3 here) seems to warn about those if either -Wall or -Wunknown-pragmas is used, but passes through it just fine; i.e., it's just build noise. I assume, Chris, that what you would like to do here is gcc ... -Wall -Wno-unknown-pragmas ... ? Note that almost all Solaris include files have #pragma ident; it's just part of the version control stuff that Sun uses. Danek -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
