Re: [Pixman] mips* asm exports symbols that should not export
On Tue, 24 Jun 2014 11:18:18 +0800 Yunqiang Su wzss...@gmail.com wrote: Is it pushed now? On Wed, Apr 9, 2014 at 12:45 AM, Nemanja Lukic nemanja.lu...@rt-rk.com wrote: Unfortunately no. I was planning to push them after that big patch set, I updated few weeks ago. Best Regards, Nemanja Lukic -Original Message- From: Søren Sandmann [mailto:soren.sandm...@gmail.com] Sent: Monday, April 7, 2014 7:45 PM To: Nemanja Lukic Cc: 'Yunqiang Su'; pixman@lists.freedesktop.org Subject: Re: [Pixman] mips* asm exports symbols that should not export Nemanja Lukic nemanja.lu...@rt-rk.com writes: Attached is solution for unwanted symbol visibility. I'll upstream both patches soon. Were these patches ever pushed? Søren If nobody has any objections or other proposals, then in a few days I'll just push the patch from http://lists.freedesktop.org/archives/pixman/2013-December/003161.html -- Best regards, Siarhei Siamashka ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
Re: [Pixman] mips* asm exports symbols that should not export
Is it pushed now? On Wed, Apr 9, 2014 at 12:45 AM, Nemanja Lukic nemanja.lu...@rt-rk.com wrote: Unfortunately no. I was planning to push them after that big patch set, I updated few weeks ago. Best Regards, Nemanja Lukic -Original Message- From: Søren Sandmann [mailto:soren.sandm...@gmail.com] Sent: Monday, April 7, 2014 7:45 PM To: Nemanja Lukic Cc: 'Yunqiang Su'; pixman@lists.freedesktop.org Subject: Re: [Pixman] mips* asm exports symbols that should not export Nemanja Lukic nemanja.lu...@rt-rk.com writes: Attached is solution for unwanted symbol visibility. I'll upstream both patches soon. Were these patches ever pushed? Søren -- Yunqiang Su ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
Re: [Pixman] mips* asm exports symbols that should not export
Unfortunately no. I was planning to push them after that big patch set, I updated few weeks ago. Best Regards, Nemanja Lukic -Original Message- From: Søren Sandmann [mailto:soren.sandm...@gmail.com] Sent: Monday, April 7, 2014 7:45 PM To: Nemanja Lukic Cc: 'Yunqiang Su'; pixman@lists.freedesktop.org Subject: Re: [Pixman] mips* asm exports symbols that should not export Nemanja Lukic nemanja.lu...@rt-rk.com writes: Attached is solution for unwanted symbol visibility. I'll upstream both patches soon. Were these patches ever pushed? Søren ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
Re: [Pixman] mips* asm exports symbols that should not export
On Thu, Dec 19, 2013 at 5:20 PM, Nemanja Lukic nemanja.lu...@rt-rk.com wrote: Hi YunQiang Su, Yes, you are right, these symbols shouldn't be exported. This is due to the fact that some optimizations were compiled (not executed) With this patch, if I use mips32r2 option to build for o32, will these symbols still be export? As I understand, these symbols are internal APIs while should never be export. Are them? where they shouldn't. Please find attached fix, that solves this issue. In the mean time I'll submit this patch on main pixman repository. Thanks and sorry for late reply, Nemanja Lukic -Original Message- From: pixman-boun...@lists.freedesktop.org [mailto:pixman-boun...@lists.freedesktop.org] On Behalf Of YunQiang Su Sent: Saturday, December 7, 2013 5:57 PM To: pixman@lists.freedesktop.org Subject: [Pixman] mips* asm exports symbols that should not export Hi, folks, When build pixman with mips64r2 options, I get some addational symbols export, while they were supposed not to be export. More details can be found in: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=719059 The build log can be found from: http://mips64el.debian.net/attempted/pixman_0.30.2-2_mips64el.build.xz -- YunQiang Su ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman -- Yunqiang Su ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
Re: [Pixman] mips* asm exports symbols that should not export
Hi YunQiang Su, Yes, you are right, these symbols shouldn't be exported. This is due to the fact that some optimizations were compiled (not executed) where they shouldn't. Please find attached fix, that solves this issue. In the mean time I'll submit this patch on main pixman repository. Thanks and sorry for late reply, Nemanja Lukic -Original Message- From: pixman-boun...@lists.freedesktop.org [mailto:pixman-boun...@lists.freedesktop.org] On Behalf Of YunQiang Su Sent: Saturday, December 7, 2013 5:57 PM To: pixman@lists.freedesktop.org Subject: [Pixman] mips* asm exports symbols that should not export Hi, folks, When build pixman with mips64r2 options, I get some addational symbols export, while they were supposed not to be export. More details can be found in: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=719059 The build log can be found from: http://mips64el.debian.net/attempted/pixman_0.30.2-2_mips64el.build.xz -- YunQiang Su ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman 0001-MIPS-DSPr2-Added-MIPS-ABI-version-check-in-configure.patch Description: Binary data ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
Re: [Pixman] mips* asm exports symbols that should not export
Hi YunQiang Su, Attached is solution for unwanted symbol visibility. I'll upstream both patches soon. Thanks, Nemanja Lukic -Original Message- From: Nemanja Lukic [mailto:nemanja.lu...@rt-rk.com] Sent: Thursday, December 19, 2013 12:30 PM To: 'Yunqiang Su' Cc: 'pixman@lists.freedesktop.org' Subject: RE: [Pixman] mips* asm exports symbols that should not export Hi YunQiang Su, Yes, if you use mips32r2 option to build for o32, these symbols will be exported (since optimizations will be compiled). And, once again, you are right, these symbols are internal API and shouldn't be exported. We need to fix this. I'm maintaining MIPS optimizations for Pixman repository, so I'll take a look, and try to fix this. Thanks for your observations, Nemanja Lukic -Original Message- From: Yunqiang Su [mailto:wzss...@gmail.com] Sent: Thursday, December 19, 2013 10:36 AM To: Nemanja Lukic Cc: pixman@lists.freedesktop.org Subject: Re: [Pixman] mips* asm exports symbols that should not export On Thu, Dec 19, 2013 at 5:20 PM, Nemanja Lukic nemanja.lu...@rt-rk.com wrote: Hi YunQiang Su, Yes, you are right, these symbols shouldn't be exported. This is due to the fact that some optimizations were compiled (not executed) With this patch, if I use mips32r2 option to build for o32, will these symbols still be export? As I understand, these symbols are internal APIs while should never be export. Are them? where they shouldn't. Please find attached fix, that solves this issue. In the mean time I'll submit this patch on main pixman repository. Thanks and sorry for late reply, Nemanja Lukic -Original Message- From: pixman-boun...@lists.freedesktop.org [mailto:pixman-boun...@lists.freedesktop.org] On Behalf Of YunQiang Su Sent: Saturday, December 7, 2013 5:57 PM To: pixman@lists.freedesktop.org Subject: [Pixman] mips* asm exports symbols that should not export Hi, folks, When build pixman with mips64r2 options, I get some addational symbols export, while they were supposed not to be export. More details can be found in: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=719059 The build log can be found from: http://mips64el.debian.net/attempted/pixman_0.30.2-2_mips64el.build.xz -- YunQiang Su ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman -- Yunqiang Su 0001-MIPS-Fix-exported-symbols-in-public-API.PATCH Description: Binary data ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
[Pixman] mips* asm exports symbols that should not export
Hi, folks, When build pixman with mips64r2 options, I get some addational symbols export, while they were supposed not to be export. More details can be found in: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=719059 The build log can be found from: http://mips64el.debian.net/attempted/pixman_0.30.2-2_mips64el.build.xz -- YunQiang Su ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
