Hi,
* Pavel Machek (pa...@suse.cz) wrote:
> On Tue 2009-01-13 15:43:07, Eric Sesterhenn wrote:
> > * Chris Mason (chris.ma...@oracle.com) wrote:
> > > On Tue, 2009-01-13 at 15:21 +0100, Eric Sesterhenn wrote:
> > > > Hi,
> > > >
> > > > when mounting an intentionally corrupted btrfs filesystem i
> The problem with 'restrict' is that almost nobody uses it, and it does
Also gcc traditionally didn't do a very good job using it (this
might be better in the very latest versions). At least some of the 3.x
often discarded this information.
> automatically. But it should work well as a way to
On Tue, Jan 20, 2009 at 08:01:52AM +1100, Linus Torvalds wrote:
>
>
> On Mon, 19 Jan 2009, Nick Piggin wrote:
> >
> > I want to know what is the problem with the restrict keyword?
> > I'm sure I've read Linus ranting about how bad it is in the
> > past...
>
> No, I don't think I've ranted about
On Mon, 19 Jan 2009, Nick Piggin wrote:
>
> I want to know what is the problem with the restrict keyword?
> I'm sure I've read Linus ranting about how bad it is in the
> past...
No, I don't think I've ranted about 'restrict'. I think it's a reasonable
solution for performance-critical code, an
On Tue 2009-01-13 15:43:07, Eric Sesterhenn wrote:
> * Chris Mason (chris.ma...@oracle.com) wrote:
> > On Tue, 2009-01-13 at 15:21 +0100, Eric Sesterhenn wrote:
> > > Hi,
> > >
> > > when mounting an intentionally corrupted btrfs filesystem i get the
> > > following warning and bug message. The im
We should probably just get an informative error message here, not a segfault.
Also, I got the same segfault when running "btrfsck -h" (it was looking for a
file named "-h". I'd be happy to contribute a getopts patch, if that is
desired.
-Zach
[zcar...@nudj btrfs-progs-unstable]$ touch foo
[z
Hello,
To improve performance, btrfs_sync_log merges tree log sync
requests. But it wrongly merges sync requests for different
tree logs. If multiple tree logs are synced at the same time,
only one tree log, only one of them actually gets synced.
This patch has following changes to fix the bug.
kthread_run() returns the kthread or ERR_PTR(-ENOMEM), not NULL.
Signed-off-by: Qinghuang Feng
---
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 81a3138..f718d25 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -1740,13 +1740,13 @@ struct btrfs_root *open_ctree(struct supe
On Sat, 2009-01-17 at 11:10 +1100, Chris Samuel wrote:
> Hi folks,
>
> Someone on the OpenMoko community list commented recently about having
> created
> a swap file on the SD card of their OpenMoko Neo phone and said that they'd
> been lazy as they'd not made a swap partition.
>
> My thought
Make several functions static, and make one argument const.
Signed-off-by: WANG Cong
---
diff --git a/btrfsck.c b/btrfsck.c
index 4a41e6d..c50de7d 100644
--- a/btrfsck.c
+++ b/btrfsck.c
@@ -1254,7 +1254,7 @@ static int fs_root_objectid(u64 objectid)
return 0;
}
-int check_fs_roots(st
bit-fields should be unsigned.
Signed-off-by: WANG Cong
---
diff --git a/btrfsck.c b/btrfsck.c
index 4a41e6d..1bf4064 100644
--- a/btrfsck.c
+++ b/btrfsck.c
@@ -60,10 +60,10 @@ struct extent_record {
struct inode_backref {
struct list_head list;
- int found_dir_item:1;
-
bit-radix.c should #include "bit-radix.h", and add a missing declaration
for find_next_bit().
Signed-off-by: WANG Cong
---
diff --git a/bit-radix.c b/bit-radix.c
index 57f6f3c..01bf4af 100644
--- a/bit-radix.c
+++ b/bit-radix.c
@@ -17,7 +17,7 @@
*/
#include "kerncompat.h"
-#include "radix-
- In bash, integer comparation should use '-eq', not '=='.
- Remove code for Mercurial, since btrfs now uses git.
Signed-off-by: WANG Cong
---
diff --git a/version.sh b/version.sh
index 92c3953..e69f8f8 100644
--- a/version.sh
+++ b/version.sh
@@ -9,7 +9,7 @@
v="Btrfs v0.17"
which git &> /d
- Remove the unused local variable 'len';
- Check return value of kmalloc().
Signed-off-by: WANG Cong
Cc: Chris Mason
---
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index db9fb3b..0e9d259 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -583,17 +583,18 @@ static long btrfs_control
On Mon, Jan 19, 2009 at 08:03:37AM -0500, Josef Bacik wrote:
>On Mon, Jan 19, 2009 at 08:57:32PM +0800, Américo Wang wrote:
>>
>> I found userspace tool, btrfsctl, uses BTRFS_VOL_NAME_MAX, and
>> it also looks that this one is more proper.
>>
>> Kill BTRFS_PATH_NAME_MAX since no one will use it.
According to the definition in kernel space, this one should be changed.
Signed-off-by: WANG Cong
---
diff --git a/btrfsctl.c b/btrfsctl.c
index e049799..5ff7f69 100644
--- a/btrfsctl.c
+++ b/btrfsctl.c
@@ -39,7 +39,7 @@
#define BLKGETSIZE64 0
#define BTRFS_IOC_SNAP_CREATE 0
#define BTRFS_VO
On Mon, Jan 19, 2009 at 08:57:32PM +0800, Américo Wang wrote:
>
> I found userspace tool, btrfsctl, uses BTRFS_VOL_NAME_MAX, and
> it also looks that this one is more proper.
>
> Kill BTRFS_PATH_NAME_MAX since no one will use it.
>
Nope, BTRFS_PATH_NAME_MAX is specifically used for the ioctl st
I found userspace tool, btrfsctl, uses BTRFS_VOL_NAME_MAX, and
it also looks that this one is more proper.
Kill BTRFS_PATH_NAME_MAX since no one will use it.
Signed-off-by: WANG Cong
Cc: Chris Mason
---
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index c2aa33e..f229950 100644
--- a/fs/bt
- Exit with non-zero when fail;
- Don't exit in non-main functions, return.
Signed-off-by: WANG Cong
---
diff --git a/btrfs-image.c b/btrfs-image.c
index 9925bdb..62b3dd8 100644
--- a/btrfs-image.c
+++ b/btrfs-image.c
@@ -741,7 +741,7 @@ static int restore_metadump(const char *input, FILE *out,
19 matches
Mail list logo
