Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line

2017-07-24 Thread Dan Carpenter
On Sat, Jul 22, 2017 at 03:51:21PM +1200, Derek Robson wrote: > Fixed checkpatch errors of "please, no spaces at the start of a line" > > Signed-off-by: Derek Robson > --- > drivers/staging/pi433/rf69.c | 4 +- > drivers/staging/pi433/rf69_enum.h | 206 >

Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line

2017-07-24 Thread Dan Carpenter
On Sat, Jul 22, 2017 at 03:51:21PM +1200, Derek Robson wrote: > Fixed checkpatch errors of "please, no spaces at the start of a line" > > Signed-off-by: Derek Robson > --- > drivers/staging/pi433/rf69.c | 4 +- > drivers/staging/pi433/rf69_enum.h | 206 >

Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line

2017-07-22 Thread Marcus Wolf
Reviewed-by: Marcus Wolf Regarding the patch for rf69.c, I'd prefer to have all mantisses allinged (all 'm' as a column below each other, all 'a' below each other, ...). For me that improves the readability a lot. Maybe that can be acchieved somehow without breaking

Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line

2017-07-22 Thread Marcus Wolf
Reviewed-by: Marcus Wolf Regarding the patch for rf69.c, I'd prefer to have all mantisses allinged (all 'm' as a column below each other, all 'a' below each other, ...). For me that improves the readability a lot. Maybe that can be acchieved somehow without breaking the style rules - but for