= twl_modules[chip];
Which obviously going to do nasty things.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
Hi Samuel,
Can you push this patch to 3.7?
Without this if the user enables the twl6030-pwm driver the kernel will not
going to boot on OMAP4.
Thank you,
Peter
drivers/mfd/twl-core.c
On 09/24/2012 10:48 AM, Takashi Iwai wrote:
At Mon, 24 Sep 2012 13:39:23 +1000,
Stephen Rothwell wrote:
Hi all,
After merging the sound tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
In file included from include/linux/skbuff.h:31:0,
from
---
Peter Ujfalusi (2):
dmaengine: Add flags parameter to dmaengine_prep_dma_cyclic()
ARM: SAMSUNG: dma-ops: Fix dmaengine_prep_dma_cyclic() parameter list
arch/arm/plat-samsung/dma-ops.c | 3 ++-
include/linux/dmaengine.h | 3 ++-
sound/soc/soc-dmaengine-pcm.c | 6 +-
3 files changed
(if DMA_PREP_INTERRUPT is cleared) when it is supported
on the platform.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Lars-Peter Clausen l...@metafoo.de
---
include/linux/dmaengine.h | 3 ++-
sound/soc/soc-dmaengine-pcm.c | 6 +-
2 files changed, 7 insertions(+), 2 deletions(-)
diff
There is a new flags parameter for the function.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
arch/arm/plat-samsung/dma-ops.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/plat-samsung/dma-ops.c b/arch/arm/plat-samsung/dma-ops.c
index c38d754..d088afa
kernel works
fine on OMAP platforms (without the patch audio was not working because
dma_alloc_writecombine() was failing, probably other things were broken as
well).
Thank you for the quick fix!
Tested-by: Peter Ujfalusi peter.ujfal...@ti.com
Cc: Mel Gorman mgor...@suse.de
Signed-off
On 10/03/2012 05:31 PM, Tim Gardner wrote:
Cc: Peter Ujfalusi peter.ujfal...@ti.com
Cc: Jarkko Nikula jarkko.nik...@bitmer.com
Cc: Liam Girdwood l...@ti.com
Cc: Mark Brown broo...@opensource.wolfsonmicro.com
Cc: Jaroslav Kysela pe...@perex.cz
Cc: Takashi Iwai ti...@suse.de
Cc: linux-o
Update the driver to use the new API for requesting pwm so we can take
advantage of the pwm_lookup table to find the correct pwm to be used for the
LED functionality.
If the devm_get_pwm fails we fall back to legacy mode to try to get the pwm.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
twl4030 (PWM driven LED A/B ports) and twl6030's
Charging indication LED (PWM driven).
Regards,
Peter
---
Peter Ujfalusi (3):
pwm: Remove pwm-twl6030 driver
pwm: New driver to support PWMs on TWL4030/6030 series of PMICs
pwm: New driver to support PWM driven LEDs on TWL4030/6030 series
.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/pwm/Kconfig | 10 ++
drivers/pwm/Makefile | 1 +
drivers/pwm/pwm-twl.c | 304 ++
3 files changed, 315 insertions(+)
create mode 100644 drivers/pwm/pwm-twl.c
diff --git a/drivers/pwm
.
When the PWM has been freed, the LED driver is put back to HW control.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/pwm/Kconfig | 10 ++
drivers/pwm/Makefile | 1 +
drivers/pwm/pwm-twl-led.c | 287 ++
3 files changed, 298
This driver only supported the Charging indicator LED.
New set of drivers going to provide support for both PWMs and LEDs for twl4030
and twl6030 series of PMICs.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/pwm/Kconfig | 9 ---
drivers/pwm/Makefile | 1
This driver only supported the Charging indicator LED.
New set of drivers going to provide support for both PWMs and LEDs for twl4030
and twl6030 series of PMICs.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/pwm/Kconfig | 9 ---
drivers/pwm/Makefile | 1
.
When the PWM has been freed, the LED driver is put back to HW control.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/pwm/Kconfig | 10 ++
drivers/pwm/Makefile | 1 +
drivers/pwm/pwm-twl-led.c | 295 ++
3 files changed, 306
,
Peter
---
Peter Ujfalusi (3):
pwm: Remove pwm-twl6030 driver
pwm: New driver to support PWMs on TWL4030/6030 series of PMICs
pwm: New driver to support PWM driven LEDs on TWL4030/6030 series of
PMICs
drivers/pwm/Kconfig | 19 ++-
drivers/pwm/Makefile | 3 +-
drivers/pwm
.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/pwm/Kconfig | 10 ++
drivers/pwm/Makefile | 1 +
drivers/pwm/pwm-twl.c | 322 ++
3 files changed, 333 insertions(+)
create mode 100644 drivers/pwm/pwm-twl.c
diff --git a/drivers/pwm
naudint parameter has not been used, remove it.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl6040-core.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/twl6040-core.c b/drivers/mfd/twl6040-core.c
index b220aa2..a46d987 100644
After the regmap_irq conversion there is no need to call the driver
as twl6040-core.c since there is only one c file remained.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/Makefile | 2 +-
drivers/mfd/{twl6040-core.c = twl6040.c} | 0
2 files changed
---
Peter Ujfalusi (6):
MFD: twl6040: Fix typo for power on failure
MFD: twl6040: Remove unused parameter for
twl6040_power_up_completion()
MFD: twl6040: Restructure power up and down code
MFD: twl6040: Correct Ready and Thermal interrupt handling
MFD: twl6040: Convert to use
Fix old copy paste bug:
automatic power-down failed - automatic power-up failed
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl6040-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/twl6040-core.c b/drivers/mfd/twl6040-core.c
index
With regmap_irq it is possibole to remove the twl6040-irq.c file and
simplify the code.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/Kconfig | 4 +-
drivers/mfd/Makefile| 2 +-
drivers/mfd/twl6040-core.c | 55
drivers/mfd/twl6040-irq.c
Create new irq handler for thermal events in order to be able to handle the
event and clean up the code regarding to interrupt handling:
Use proper function names for the irq handlers
No need to read the INTD register anymore.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd
Rearrange the code path for power up and down sequence.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl6040-core.c | 38 ++
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git a/drivers/mfd/twl6040-core.c b/drivers/mfd/twl6040
twl4030-madc driver can only handle twl4030 class MADC. The newer revisions
of twl does not have MADC, instead they have different IP called GPADC which
is not backward compatible.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
Hi Samuel,
When building the kernel to support OMAP3/4/5 we
Support for device tree booted kernel.
When the kernel is booted with DeviceTree blob we support one led per
leds-pwm device to have cleaner integration with the PWM subsystem.
For usage see:
Documentation/devicetree/bindings/leds/leds-pwm.txt
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
with Device tree we handle one LED per device to be more aligned
with PWM core's DT implementation.
An example of the DT usage is provided in the new DT binding documentation for
leds-pwm.
Tested on OMAP4 Blaze (SDP) with legacy and DT boot.
Regards,
Peter
---
Peter Ujfalusi (3):
leds: leds-pwm
In order to be able to add device tree support for leds-pwm driver we need
to rearrange the data structures used by the drivers.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/leds/leds-pwm.c | 39 +++
1 file changed, 23 insertions(+), 16
Update the driver to use the new API for requesting pwm so we can take
advantage of the pwm_lookup table to find the correct pwm to be used for the
LED functionality.
If the devm_get_pwm fails we fall back to legacy mode to try to get the pwm.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
Hi Samuel,
On 11/01/2012 10:09 AM, Tero Kristo wrote:
Acked-by: Tero Kristo t-kri...@ti.com
Can you take this patch for 3.7?
Thank you,
Péter
On Wed, 2012-10-31 at 15:54 +0100, Peter Ujfalusi wrote:
The correct chip id is 1 since the PWM module is on address 0x49. With the
current
Hi Samuel,
On 10/11/2012 01:55 PM, Peter Ujfalusi wrote:
Hello,
This series will convert the twl6040 MFD core driver to use regmap_irq instead
of the custom interrupt code it used. In this way considerable amount of code
can be removed and we are going to use common, well tested code
twl4030-madc driver can only handle twl4030 class MADC. The newer revisions
of twl does not have MADC, instead they have different IP called GPADC which
is not backward compatible.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl-core.c | 3 ++-
1 file changed, 2
can switch to use
it as soon as it is possible.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl-core.c | 9 +++
include/linux/i2c/twl.h | 65 +
2 files changed, 36 insertions(+), 38 deletions(-)
diff --git a/drivers
To facilitate upcoming cleanup in twl stack.
No functional changes.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl4030-power.c | 124 ++--
1 file changed, 51 insertions(+), 73 deletions(-)
diff --git a/drivers/mfd/twl4030-power.c
Since the twl-core has been converted to use regmap it is no longer needed
to allocate bigger buffer for data when writing to twl.
CC: Grant Likely grant.lik...@secretlab.ca
CC: Linus Walleij linus.wall...@linaro.org
CC: Alessandro Zummo a.zu...@towertech.it
Signed-off-by: Peter Ujfalusi
Remove the custom code to do I/O and replace it with standard regmap calls.
CC: Mark Brown broo...@opensource.wolfsonmicro.com
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl-core.c | 147 +++--
1 file changed, 80 insertions
It is easier fro humans to understand decimal numbers than hexadecimals when
they are used as indexes.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
include/linux/i2c/twl.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/i2c/twl.h b/include/linux
To facilitate upcoming cleanup in twl stack.
No functional changes.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl-core.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index f857097
To facilitate upcoming cleanup in twl stack.
No functional changes.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl4030-irq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index e900402
To facilitate upcoming cleanup in twl stack.
No functional changes.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl4030-madc.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/mfd/twl4030-madc.c b/drivers/mfd/twl4030-madc.c
index
Group the twl_mapping table in 5 lines chunks so it is more easier to find
the row we are looking for (if we need to).
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl-core.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/twl
.
The series depends on a regression fix patch for the twl-core:
https://patchwork.kernel.org/patch/1679421/
Regards,
Peter
---
Peter Ujfalusi (13):
MFD: twl-core: Register twl4030-madc child only for twl4030 class
MFD: twl-core: Support for proper PWM drivers
MFD: twl-core: Convert to use
on 0x4b address and not 0x48
twl4030_pwrbutton is accessible on 0x4b address and not 0x49
twl4030-audio is on 0x49 all the time
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl-core.c | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git
AUDIO and MADC only available on twl4030 series and the TWL_MODULE_* mapping
is not needed.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
include/linux/i2c/twl.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h
index 9a5e284
instance) while the twl-pwmled
driver is to control the two LED instance on TWL4030 and to charging
indicator LED (1 instance) on TWL6030.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl-core.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git
Avoid using the TWL4030_MODULE_PWMA/B as module ID. The LEDEN, PWMA ON/OFF
and PWMB ON/OFF registers are in a continuous range starting from LED base.
This is going to be helpful for further cleanup in the twl stack.
No functional changes.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
To facilitate upcoming cleanup in twl stack.
No functional changes.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/input/misc/twl4030-pwrbutton.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/input/misc/twl4030-pwrbutton.c
b/drivers/input/misc
To facilitate upcoming cleanup in twl stack.
No functional changes.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/watchdog/twl4030_wdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/twl4030_wdt.c b/drivers/watchdog/twl4030_wdt.c
index
To facilitate upcoming cleanup in twl stack.
No functional changes.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/power/twl4030_charger.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/power/twl4030_charger.c b/drivers/power
To facilitate upcoming cleanup in twl stack.
No functional changes.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/usb/otg/twl4030-usb.c | 46 ---
1 file changed, 21 insertions(+), 25 deletions(-)
diff --git a/drivers/usb/otg/twl4030
Hi Felipe,
On 11/13/2012 10:47 AM, Felipe Balbi wrote:
On Tue, Nov 13, 2012 at 10:43:38AM +0100, Peter Ujfalusi wrote:
To facilitate upcoming cleanup in twl stack.
No functional changes.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
I guess this one must go together with the rest
On 11/13/2012 11:37 AM, Felipe Balbi wrote:
ok good. Unfortunately I have already sent this merge window's pull
request to Greg so I'd have to delay this until v3.9. If that's ok with
you, I can take it through my tree.
I hoped that this can go with 3.8 since in 3.9 I'm planning to remove all
Hi Bryan,
On 11/14/2012 02:14 AM, Bryan Wu wrote:
diff --git a/include/linux/leds_pwm.h b/include/linux/leds_pwm.h
index 33a0711..a65e964 100644
--- a/include/linux/leds_pwm.h
+++ b/include/linux/leds_pwm.h
@@ -7,7 +7,7 @@
struct led_pwm {
const char *name;
const
TWL_MODULE_PWM is defined as:
#define TWL_MODULE_PWM TWL4030_MODULE_PWM0
Use the common module ID define here which will facilitate the upcoming
twl-core cleanup.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/video/backlight/pandora_bl.c | 8 +++-
1 file changed
Appear to be a copy-paste bug: the code was checking board_data-dsi_enable_pads
while calling board_data-dsi_disable_pads.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
Hi Tomi,
not sure if this need to be included to 3.7
Regards,
Peter
drivers/video/omap2/dss/core.c | 2 +-
1
Hello,
The following series fixes the revision information for twl6040 and adds support
for twl6041.
While the first patch is changing a driver in sound/soc/codecs the series can go
via MFD since we do not have pending patches for twl6040 audio part for 3.6.
Regards,
Peter
---
Peter Ujfalusi (2
twl6040 ES1.1 and ES1.2 have the same revid (0x01).
ES1.3 of twl6040 REVID is 0x02.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
include/linux/mfd/twl6040.h |4 ++--
sound/soc/codecs/twl6040.c |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux
The delta between twl6040 and twl6041 is small, the main difference is in
the number of GPOs (3 on twl6040, 1 on twl6041).
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
Documentation/devicetree/bindings/mfd/twl6040.txt |2 +-
drivers/mfd/twl6040-core.c|1
On 07/17/2012 08:39 AM, Rajeev kumar wrote:
#define TWL6040_REV_ES1_00x00
-#define TWL6040_REV_ES1_10x01
-#define TWL6040_REV_ES1_20x02
+#define TWL6040_REV_ES1_10x01 /* Rev ES1.1 and ES1.2 */
+#define TWL6040_REV_ES1_30x02
#define TWL6040_IRQ_TH
tree (twl6040
revision fixes, twl6041 support).
Linus, Grant, Samuel: Would it be possible to queue this series via the MFD tree
to avoid merge issues? It applies cleanly on top of gpio-next I believe it will
not cause problems via MFD.
Regards,
Peter
---
Peter Ujfalusi (3):
mfd: twl6040: Fix
TWL6040 provides GPO lines to be used for controlling external devices.The
number
of lines different between versions: twl6040 have 3 GPO while TWL6041 have 1.
Signed-off-by: Sergio Aguirre saagui...@ti.com
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/gpio/Kconfig
Add needed platform data structure and code to be able to load
the GPO child of twl6040.
Update the devicetree binding documentation at the same time.
Signed-off-by: Sergio Aguirre saagui...@ti.com
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
Documentation/devicetree/bindings/mfd
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
include/linux/mfd/twl6040.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/mfd/twl6040.h b/include/linux/mfd/twl6040.h
index eaad49f..269b706 100644
--- a/include/linux/mfd/twl6040.h
+++ b/include
probe function.
Reported-by: Christoph Fritz chf.fr...@googlemail.com
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
Hi Tony, Alessandro, Christoph,
I think this patch is the correct solution for the issue Christoph reported:
http://www.spinics.net/lists/linux-omap/msg89980.html
We can
Hi Tomi,
On 04/16/2013 10:10 AM, Tomi Valkeinen wrote:
Hi,
On 2013-04-16 10:44, Peter Ujfalusi wrote:
Convert the driver to use module_platform_driver() to register the platform
driver and relocate the rtc_reg_map initialization to platform driver's
probe function.
In this way we can make
Use module_platform_driver() to register the platform driver.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/rtc/rtc-twl.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
index c385e9b..22b2fd6 100644
it's
init.
Reported-by: Christoph Fritz chf.fr...@googlemail.com
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
Hi,
As Tomi commented on the first version:
www.spinics.net/lists/linux-omap/msg90064.html
www.spinics.net/lists/linux-omap/msg90066.html
I have separated the actual fix from
Russell,
On 04/03/2013 01:17 PM, Peter Ujfalusi wrote:
cyclic DMA is only used by audio which needs DMA to be started without a
delay.
If the DMA for audio is started using the tasklet we experience random
channel switch (to be more precise: channel shift).
Reported-by: Peter Meerwald pme
On 04/09/2013 08:52 AM, Santosh Shilimkar wrote:
I suggest Peter resend the patch with also Grant + Linus W cc:d so
they can queue it unless there are other related patches pending
somewhere else.
Am curious on your suggestion. DMA engine patches are going via Vinod
Koul's tree so I think
On 04/08/2013 07:09 PM, Russell King - ARM Linux wrote:
Now that I'm back from a short 4 day break, then yes, and the answer is
that it's fine. Who's handling the patch?
Thank you,
Péter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
Russell,
On 04/09/2013 09:19 AM, Peter Ujfalusi wrote:
On 04/08/2013 07:09 PM, Russell King - ARM Linux wrote:
Now that I'm back from a short 4 day break, then yes, and the answer is
that it's fine. Who's handling the patch?
Thank you,
Péter
Can I add you acked-by to the patch
On 04/09/2013 09:26 AM, Vinod Koul wrote:
Yes it should go thru dmaengine tree, sorry was travelling hence the delay,
pls
resend the patch and I will do the needful
I already have the patch rebased on today's linux-next, just waiting for
Russell to confirm that I can add his Acked-by to the
-by: Peter Ujfalusi peter.ujfal...@ti.com
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
Acked-by: Russell King rmk+ker...@arm.linux.org.uk
---
Hi Vinod,
Would it be possible to send this patch for 3.9. The channel shift (or switch)
issue in audio has been noticed recently and it turns out
Remove the use of a tasklet to start the DMA channel when issue_pending is
called.
The use of tasklet delays the DMA start which can cause issues at drivers,
for example the audio drivers expect that the DMA is started right away.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
Hi Russell
On 03/31/2013 05:07 PM, Axel Lin wrote:
Return proper error instead of 0 if twl6030_pwm_enable() fails.
Signed-off-by: Axel Lin axel@ingics.com
Acked-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/pwm/pwm-twl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On 03/31/2013 05:16 AM, Axel Lin wrote:
Add missing .owner of struct pwm_ops. This prevents the module from being
removed from underneath its users.
Signed-off-by: Axel Lin axel@ingics.com
Acked-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/pwm/pwm-twl-led.c |2 ++
1 file
On 03/31/2013 05:17 AM, Axel Lin wrote:
Add missing .owner of struct pwm_ops. This prevents the module from being
removed from underneath its users.
Signed-off-by: Axel Lin axel@ingics.com
Acked-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/pwm/pwm-twl.c |2 ++
1 file
Russell,
On 03/29/2013 06:31 PM, Russell King - ARM Linux wrote:
On Fri, Mar 29, 2013 at 03:12:03PM +0100, Peter Ujfalusi wrote:
Remove the use of a tasklet to start the DMA channel when issue_pending is
called.
The use of tasklet delays the DMA start which can cause issues at drivers
cyclic DMA is only used by audio which needs DMA to be started without a
delay.
If the DMA for audio is started using the tasklet we experience random
channel switch (to be more precise: channel shift).
Reported-by: Peter Meerwald pme...@pmeerw.net
Signed-off-by: Peter Ujfalusi peter.ujfal
On 04/03/2013 01:24 PM, Santosh Shilimkar wrote:
On Wednesday 03 April 2013 04:47 PM, Peter Ujfalusi wrote:
cyclic DMA is only used by audio which needs DMA to be started without a
delay.
If the DMA for audio is started using the tasklet we experience random
channel switch (to be more precise
Hi,
On 03/11/2013 04:58 PM, Silviu-Mihai Popescu wrote:
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages so all explicit
error messages can be
On 03/12/2013 09:24 AM, Silviu Popescu wrote:
As far as I can tell from the mails that you have provided, those
patches replace devm_request_mem_region(), followed by devm_ioremap()
with devm_request_and_ioremap().
What this patch attempts to do is replace devm_request_and_ioremap()
with the
be removed from the failure code paths.
Acked-by: Peter Ujfalusi peter.ujfal...@ti.com
Signed-off-by: Silviu-Mihai Popescu silviupopescu1...@gmail.com
---
sound/soc/omap/omap-dmic.c |9 +++--
sound/soc/omap/omap-mcpdm.c |8 +++-
2 files changed, 6 insertions(+), 11 deletions
On 03/12/2013 04:20 PM, Roger Quadros wrote:
Adding Peter to the loop. I faintly remember him mentioning this issue before
for beagle. We really need the deferred probe mechanism or we need to resort
to device registering order.
Yes, BeagleBoard is a good example. Long story short: we have
On 11/28/2012 08:30 PM, Thierry Reding wrote:
I must say I'm not terribly thrilled to integrate something like this
into the PWM subsystem.
I agree. I would not really want to add my name to something like this either...
I wish hardware engineers wouldn't come up with such designs.
I have
On 11/30/2012 11:20 AM, Grant Likely wrote:
Umm, I agree with you on duty cycle, but that's got nothing to do with
period. 100% duty cycle looks exactly the same whether the period is
10ns or 100s.
Yes this is true. But some PWM hw can select it's clock based on the period_ns
provided.
In most
On 11/29/2012 05:10 PM, Grant Likely wrote:
/* Enable GPIO us of the PWMs */
gpio-controller = 1;
This line should be simply (the property shouldn't have any data):
gpio-controller;
Yes I know. It is like this already in my code. I just mixed up things while
hacking it
Hi Bryan,
On 11/14/2012 02:14 AM, Bryan Wu wrote:
On Mon, Nov 12, 2012 at 6:41 AM, Peter Ujfalusi peter.ujfal...@ti.com wrote:
Update the driver to use the new API for requesting pwm so we can take
advantage of the pwm_lookup table to find the correct pwm to be used for the
LED functionality
Hi Bryan,
On 12/03/2012 07:32 PM, Bryan Wu wrote:
On Mon, Dec 3, 2012 at 6:13 AM, Peter Ujfalusi peter.ujfal...@ti.com wrote:
Actually, I'm waiting for some feedback from DT maintainers about this
new binding. But it looks find to me.
Would it be possible to have the first (or even better
When the GPIO is configured as output we need to read the GPIODATAOUT*
register to get correct information. When the GPIO is output the GPIODATAIN*
registers report 0 all the time (no feedback from output path).
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/gpio/gpio-twl4030.c
On 12/04/2012 06:34 PM, Bryan Wu wrote:
What's best thing I can do is I can merge these patchset into my
-devel branch, after 3.8 merge window close I will move this -devel
branch to my for-next branch for 3.9 merge window.
Does this make sense to you?
Not sure if I can get changes related
to the beginning of the twl_i2c_read/write function because
twl_get_last_module() also uses the twl_priv structure.
Signed-off-by: Jon Hunter jon-hun...@ti.com
Acked-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl-core.c | 16
1 file changed, 8 insertions(+), 8
On 02/10/2013 04:21 PM, Anil Kumar wrote:
Hi All,
I am working on Devkit8000 and adding DT support for that. I am trying
to add sound DT node support for this boards.
I have nearly done with this but facing issue on record. I do not have
much knowledge of twl4030 audio codec but with
small
Hi,
On 02/11/2013 06:58 PM, Anil Kumar wrote:
Here you should have something like:
ti,audio-routing =
Ext Spk, PREDRIVEL,
Ext Spk, PREDRIVER,
MAINMIC, Main Mic,
Main Mic, Mic Bias 1;
So you connect the MicBias1 to Main Mic. When you start playback MicBias1
On 02/11/2013 09:22 PM, Jon Hunter wrote:
Good point. I just noticed that none of my omap2+ board were booting and
on omap3/4 I was the panic in the twl code. I can't say that I checked
the panic on omap2, so may be that was another problem?
Do you have insights on the code path leading to a
Hi Jon,
On 02/12/2013 05:15 PM, Jon Hunter wrote:
On 02/12/2013 01:26 AM, Peter Ujfalusi wrote:
On 02/11/2013 09:22 PM, Jon Hunter wrote:
Good point. I just noticed that none of my omap2+ board were booting and
on omap3/4 I was the panic in the twl code. I can't say that I checked
On 01/29/2013 11:17 AM, Thierry Reding wrote:
On Tue, Jan 29, 2013 at 09:17:04AM +0100, Peter Ujfalusi wrote:
On 01/28/2013 10:01 PM, Thierry Reding wrote:
On Tue, Jan 22, 2013 at 02:39:53PM +0100, Peter Ujfalusi wrote:
It is expected that board files would have:
static unsigned int bl_levels
On 01/29/2013 01:30 PM, Thierry Reding wrote:
Right. Now I know the background.
However I do not agree with the conclusion. Probably it is fine in some cases
to limit the number of configurable duty cycles to have only distinct steps.
To not go too far, on my laptop I have:
# cat
Currently it is possible to have:
USB_MUSB_OMAP2PLUS=m
TWL4030_USB=y
which would result compile time error due to missing symbols.
With this change USB_MUSB_OMAP2PLUS and TWL4030_USB will be in sync.
Reported-by: Vincent Stehle v-ste...@ti.com
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
Hi Thierry,
On 01/22/2013 02:39 PM, Peter Ujfalusi wrote:
Move the dft_brightness validity check from the DT parsing function to the
main probe. In this way we can validate it in case we are booting with or
without DT.
Based on the discussion the rest of the series is going to be dropped
On 03/02/2013 08:30 AM, Mark Brown wrote:
Looks like the conversion to enum was missed for the definition of this
function, the declaration has been updated.
Acked-by: Peter Ujfalusi peter.ujfal...@ti.com
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/mfd
1 - 100 of 4568 matches
Mail list logo
